From: Tony Lindgren <tony@atomide.com>
To: Nick Bowler <nbowler@draconx.ca>
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
regressions@lists.linux.dev, linux-serial@vger.kernel.org
Subject: Re: PROBLEM: Sun Ultra 60 hangs on boot since Linux 6.8
Date: Fri, 22 Mar 2024 07:15:32 +0200 [thread overview]
Message-ID: <20240322051531.GA5132@atomide.com> (raw)
In-Reply-To: <d84baa5d-a092-3647-8062-ed7081d329d4@draconx.ca>
Hi,
* Nick Bowler <nbowler@draconx.ca> [240322 04:29]:
> I bisected to this commit:
>
> commit 45a3a8ef81291b63a2b50a1a145857dd9fc05e89
> Author: Tony Lindgren <tony@atomide.com>
> Date: Mon Nov 13 10:07:53 2023 +0200
>
> serial: core: Revert checks for tx runtime PM state
>
> Reverting this commit on top of Linux 6.8 is sufficient to get the
> system booting again.
Thanks a lot for bisecting and reporting the issue.
Can you please test if the following change to add back the check for
!pm_runtime_active() is enough to fix the issue?
Regards,
Tony
8< -----------------------
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -156,7 +156,7 @@ static void __uart_start(struct uart_state *state)
* enabled, serial_port_runtime_resume() calls start_tx() again
* after enabling the device.
*/
- if (pm_runtime_active(&port_dev->dev))
+ if (!pm_runtime_enabled(&port_dev->dev) || pm_runtime_active(&port_dev->dev))
port->ops->start_tx(port);
pm_runtime_mark_last_busy(&port_dev->dev);
pm_runtime_put_autosuspend(&port_dev->dev);
--
2.44.0
next parent reply other threads:[~2024-03-22 5:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d84baa5d-a092-3647-8062-ed7081d329d4@draconx.ca>
2024-03-22 5:15 ` Tony Lindgren [this message]
2024-03-22 6:36 ` PROBLEM: Sun Ultra 60 hangs on boot since Linux 6.8 Nick Bowler
2024-03-22 6:48 ` Tony Lindgren
2024-03-22 9:06 ` Tony Lindgren
2024-03-22 14:12 ` Nick Bowler
2024-03-23 6:49 ` Tony Lindgren
2024-03-25 7:39 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322051531.GA5132@atomide.com \
--to=tony@atomide.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nbowler@draconx.ca \
--cc=regressions@lists.linux.dev \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).