From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Stephen Smalley <stephen.smalley.work@gmail.com>,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH] lsm: fix default return value of the socket_getpeersec_* hooks
Date: Tue, 30 Jan 2024 17:01:53 -0500 [thread overview]
Message-ID: <4af3b3fce8fed039ffa0526549db95fa@paul-moore.com> (raw)
In-Reply-To: <20240126184531.1167999-1-omosnace@redhat.com>
On Jan 26, 2024 Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> For these hooks the true "neutral" value is -EOPNOTSUPP, which is
> currently what is returned when no LSM provides this hook and what LSMs
> return when there is no security context set on the socket. Correct the
> value in <linux/lsm_hooks.h> and adjust the dispatch functions in
> security/security.c to avoid issues when the BPF LSM is enabled.
>
> Fixes: 98e828a0650f ("security: Refactor declaration of LSM hooks")
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> ---
> include/linux/lsm_hook_defs.h | 4 ++--
> security/security.c | 31 +++++++++++++++++++++++++++----
> 2 files changed, 29 insertions(+), 6 deletions(-)
I was originally going to merge this via lsm/dev, but thinking about
this some more today, and considering the other inode_getsecctx() fix,
I think this patch should be marked for stable too.
I'm going to merge this into lsm/stable-6.8 and assuming all the tests
come back clean (which they should), I'll send this up to Linus
tomorrow with the inode_getsecctx() fix.
Thanks all!
--
paul-moore.com
prev parent reply other threads:[~2024-01-30 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 18:45 [PATCH] lsm: fix default return value of the socket_getpeersec_* hooks Ondrej Mosnacek
2024-01-29 23:02 ` Paul Moore
2024-01-29 23:25 ` Casey Schaufler
2024-01-30 3:01 ` Paul Moore
2024-01-30 8:29 ` Ondrej Mosnacek
2024-01-30 16:17 ` Casey Schaufler
2024-01-30 22:01 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4af3b3fce8fed039ffa0526549db95fa@paul-moore.com \
--to=paul@paul-moore.com \
--cc=linux-security-module@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).