From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH net 2/3] Documentation: add description for net.sctp.intl_enable
Date: Mon, 6 Jun 2022 16:20:53 -0300 [thread overview]
Message-ID: <Yp5TlffV0mIdg7Qp@t14s.localdomain> (raw)
In-Reply-To: <1fc59e854d7b9c66f4ab681dbe2a9eb91219f3a4.1654279751.git.lucien.xin@gmail.com>
Hi,
On Fri, Jun 03, 2022 at 02:09:24PM -0400, Xin Long wrote:
> Describe it in networking/ip-sysctl.rst like other SCTP options.
> We need to document this especailly as when using the feature
especially
> of User Message Interleaving, some socket options also needs
> to be set.
>
> Fixes: 463118c34a35 ("sctp: support sysctl to allow users to use stream interleave")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> Documentation/networking/ip-sysctl.rst | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 3abd494053a9..b67f2f83ff32 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -2941,6 +2941,20 @@ reconf_enable - BOOLEAN
>
> Default: 0
>
> +intl_enable - BOOLEAN
> + Enable or disable extension of User Message Interleaving functionality
> + specified in RFC8260. This extension allow the interleaving of user
allows
> + messages sent on different streams. With this feature enabled, I-DATA
> + chunk will replace DATA chunk to carry user messages. Note that to use
.. to carry user messages if also supported by the peer.
> + this feature, with this option set to 1, we also need socket options
> + SCTP_FRAGMENT_INTERLEAVE set to 2 and SCTP_INTERLEAVING_SUPPORTED set
> + to 1.
Perhaps for this last sentence:
Note that to use this feature, one needs to set this option to 1 and
also need to set socket options SCTP_FRAGMENT_INTERLEAVE to 2 and
SCTP_INTERLEAVING_SUPPORTED to 1.
My only comments on the set. Otherwise LGTM.
> +
> + - 1: Enable extension.
> + - 0: Disable extension.
> +
> + Default: 0
> +
>
> ``/proc/sys/net/core/*``
> ========================
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-06-06 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 18:09 [PATCH net 0/3] Documentation: add description for a couple of sctp sysctl options Xin Long
2022-06-03 18:09 ` [PATCH net 1/3] Documentation: add description for net.sctp.reconf_enable Xin Long
2022-06-03 18:09 ` [PATCH net 2/3] Documentation: add description for net.sctp.intl_enable Xin Long
2022-06-06 19:20 ` Marcelo Ricardo Leitner [this message]
2022-06-03 18:09 ` [PATCH net 3/3] Documentation: add description for net.sctp.ecn_enable Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5TlffV0mIdg7Qp@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).