* [PATCH] dm-mpath: Fixing unnecessary argument casting
@ 2010-01-05 18:39 Moger, Babu
2010-01-06 1:38 ` [dm-devel] " Kiyoshi Ueda
0 siblings, 1 reply; 2+ messages in thread
From: Moger, Babu @ 2010-01-05 18:39 UTC (permalink / raw
To: dm-devel@redhat.com, linux-scsi@vger.kernel.org; +Cc: Chandra Seetharaman
This patch removes couple of unnecessary argument casting. There is no functional change with this patch.
Tested the changes with LSI storage..
CC: Chandra Seetharaman <chandra.seetharaman@us.ibm.com>
Signed-off-by: Babu Moger <babu.moger@lsi.com>
---
--- linux-2.6.33-rc2/drivers/md/dm-mpath.c.orig 2010-01-05 12:47:26.000000000 -0400
+++ linux-2.6.33-rc2/drivers/md/dm-mpath.c 2010-01-05 12:34:00.000000000 -0400
@@ -1128,8 +1128,7 @@ static int pg_init_limit_reached(struct
static void pg_init_done(void *data, int errors)
{
- struct dm_path *path = data;
- struct pgpath *pgpath = path_to_pgpath(path);
+ struct pgpath *pgpath = data;
struct priority_group *pg = pgpath->pg;
struct multipath *m = pg->m;
unsigned long flags;
@@ -1198,7 +1197,7 @@ static void activate_path(struct work_st
container_of(work, struct pgpath, activate_path);
scsi_dh_activate(bdev_get_queue(pgpath->path.dev->bdev),
- pg_init_done, &pgpath->path);
+ pg_init_done, pgpath);
}
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dm-devel] [PATCH] dm-mpath: Fixing unnecessary argument casting
2010-01-05 18:39 [PATCH] dm-mpath: Fixing unnecessary argument casting Moger, Babu
@ 2010-01-06 1:38 ` Kiyoshi Ueda
0 siblings, 0 replies; 2+ messages in thread
From: Kiyoshi Ueda @ 2010-01-06 1:38 UTC (permalink / raw
To: device-mapper development; +Cc: linux-scsi@vger.kernel.org, Chandra Seetharaman
Hi,
I have the exact same patch.
On 2010/01/06 3:39 +0900, Moger, Babu wrote:
> This patch removes couple of unnecessary argument casting. There is no functional change with this patch.
> Tested the changes with LSI storage..
>
> CC: Chandra Seetharaman <chandra.seetharaman@us.ibm.com>
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> ---
> --- linux-2.6.33-rc2/drivers/md/dm-mpath.c.orig 2010-01-05 12:47:26.000000000 -0400
> +++ linux-2.6.33-rc2/drivers/md/dm-mpath.c 2010-01-05 12:34:00.000000000 -0400
> @@ -1128,8 +1128,7 @@ static int pg_init_limit_reached(struct
>
> static void pg_init_done(void *data, int errors)
> {
> - struct dm_path *path = data;
> - struct pgpath *pgpath = path_to_pgpath(path);
> + struct pgpath *pgpath = data;
> struct priority_group *pg = pgpath->pg;
> struct multipath *m = pg->m;
> unsigned long flags;
> @@ -1198,7 +1197,7 @@ static void activate_path(struct work_st
> container_of(work, struct pgpath, activate_path);
>
> scsi_dh_activate(bdev_get_queue(pgpath->path.dev->bdev),
> - pg_init_done, &pgpath->path);
> + pg_init_done, pgpath);
> }
>
> /*
Acked-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Thanks,
Kiyoshi Ueda
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-06 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-05 18:39 [PATCH] dm-mpath: Fixing unnecessary argument casting Moger, Babu
2010-01-06 1:38 ` [dm-devel] " Kiyoshi Ueda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).