From: Mike Christie <michael.christie@oracle.com>
To: Khazhismel Kumykov <khazhy@chromium.org>,
Lee Duncan <lduncan@suse.com>, Chris Leech <cleech@redhat.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Khazhismel Kumykov <khazhy@google.com>
Subject: Re: [PATCH 2/2] iscsi_tcp: disallow binding the same connection twice
Date: Tue, 19 Mar 2024 14:33:56 -0500 [thread overview]
Message-ID: <6bc61553-6c8e-4705-9cbb-8e73d3f8c801@oracle.com> (raw)
In-Reply-To: <20240318194902.3290795-2-khazhy@google.com>
On 3/18/24 2:49 PM, Khazhismel Kumykov wrote:
> iscsi_sw_tcp_conn_bind does not check or cleanup previously bound
> sockets, nor should we allow binding the same connection twice.
>
This looks like a problem for all the iscsi drivers.
I think you could:
1. Add a check for ISCSI_CONN_FLAG_BOUND in iscsi_conn_bind.
2. Have iscsi_sw_tcp_conn_stop do:
/* stop xmit side */
- iscsi_suspend_tx(conn);
+ iscsi_conn_unbind(cls_conn, true);
to clear the flag when we clean up the conn for relogin.
3. Fix up the other iscsi drivers so they call:
iscsi_conn_unbind(cls_conn, true);
in their failure paths so when they fail they clear ISCSI_CONN_FLAG_BOUND and
iscsi_conn_bind can be called on the retry.
> Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
> ---
> drivers/scsi/iscsi_tcp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index e8ed60b777c6..8cf5dc203a82 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -716,6 +716,9 @@ iscsi_sw_tcp_conn_bind(struct iscsi_cls_session *cls_session,
> struct socket *sock;
> int err;
>
> + if (tcp_sw_conn->sock)
> + return -EINVAL;
> +
> /* lookup for existing socket */
> sock = sockfd_lookup((int)transport_eph, &err);
> if (!sock) {
next prev parent reply other threads:[~2024-03-19 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 19:49 [PATCH 1/2] iscsi_tcp: do not bind sockets that already have extra callbacks Khazhismel Kumykov
2024-03-18 19:49 ` [PATCH 2/2] iscsi_tcp: disallow binding the same connection twice Khazhismel Kumykov
2024-03-19 19:33 ` Mike Christie [this message]
2024-05-23 22:25 ` Khazhy Kumykov
2024-03-19 19:28 ` [PATCH 1/2] iscsi_tcp: do not bind sockets that already have extra callbacks Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc61553-6c8e-4705-9cbb-8e73d3f8c801@oracle.com \
--to=michael.christie@oracle.com \
--cc=cleech@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=khazhy@chromium.org \
--cc=khazhy@google.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).