From: Chanwoo Lee <cw9316.lee@samsung.com>
To: cw9316.lee@samsung.com
Cc: James.Bottomley@HansenPartnership.com, alim.akhtar@samsung.com,
avri.altman@wdc.com, bvanassche@acm.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, powen.kao@mediatek.com,
quic_cang@quicinc.com, quic_nguyenb@quicinc.com,
stanley.chu@mediatek.com, yang.lee@linux.alibaba.com
Subject: Re: Re: [PATCH] ufs:mcq:Fixing Error Output for ufshcd_try_to_abort_task in ufshcd_mcq_abort
Date: Fri, 24 May 2024 08:56:13 +0900 [thread overview]
Message-ID: <20240523235613.1103161-1-cw9316.lee@samsung.com> (raw)
In-Reply-To: <20240523002257.1068373-1-cw9316.lee@samsung.com>
On 5/23/24 22:43, Bart Van Assche wrote:
>On 5/22/24 17:22, Chanwoo Lee wrote:
>> An error unrelated to ufshcd_try_to_abort_task is being output and
>> can cause confusion. So, I modified it to output the result of abort
>> fail. This modification was similarly revised by referring to the
>> ufshcd_abort function.
>>
>> Signed-off-by: Chanwoo Lee <cw9316.lee@samsung.com>
>> ---
>> drivers/ufs/core/ufs-mcq.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
>> index 005d63ab1f44..fc24d1af1fe8 100644
>> --- a/drivers/ufs/core/ufs-mcq.c
>> +++ b/drivers/ufs/core/ufs-mcq.c
>> @@ -667,9 +667,11 @@ int ufshcd_mcq_abort(struct scsi_cmnd *cmd)
>> * in the completion queue either. Query the device to see if
>> * the command is being processed in the device.
>> */
>> - if (ufshcd_try_to_abort_task(hba, tag)) {
>> + err = ufshcd_try_to_abort_task(hba, tag);
>> + if (err) {
>> dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err);
>> lrbp->req_abort_skip = true;
>> + err = FAILED;
>> goto out;
>> }
>
>Why does the word "Fixing" occur in the title of this patch? I think
>that this patch does not affect the value returned by
>ufshcd_mcq_abort(). From the start of that function:
>
>int err = FAILED;
>
>Thanks,
>
>Bart.
I thought this patch would be appropriate to "fix" the following log.
* dev_err(hba->dev, "%s: device abort failed %d\n", __func__, err);
If "Fixing" is not appropriate, could you suggest another word?
Thanks,
Chanwoo Lee.
next prev parent reply other threads:[~2024-05-23 23:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240523002322epcas1p2a63dfc646a2b2dd8fcadad2a8807bcee@epcas1p2.samsung.com>
2024-05-23 0:22 ` [PATCH] ufs:mcq:Fixing Error Output for ufshcd_try_to_abort_task in ufshcd_mcq_abort Chanwoo Lee
2024-05-23 22:43 ` Bart Van Assche
[not found] ` <CGME20240523235615epcas1p282b2405bed41b94ef8a40633066f1d4c@epcas1p2.samsung.com>
2024-05-23 23:56 ` Chanwoo Lee [this message]
2024-05-24 0:08 ` Bart Van Assche
[not found] ` <CGME20240524001842epcas1p3a66b301f7aad3a8da28869db634221d1@epcas1p3.samsung.com>
2024-05-24 0:18 ` Chanwoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240523235613.1103161-1-cw9316.lee@samsung.com \
--to=cw9316.lee@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=powen.kao@mediatek.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=stanley.chu@mediatek.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).