From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Manish Rangankar <mrangankar@marvell.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
GR-QLogic-Storage-Upstream@marvell.com,
linux-scsi@vger.kernel.org, Martin Hoyer <mhoyer@redhat.com>,
John Meneghini <jmeneghi@redhat.com>
Subject: Re: [PATCH v2] qedi: Fix crash while reading debugfs attribute.
Date: Mon, 6 May 2024 21:59:51 -0400 [thread overview]
Message-ID: <171504445058.1494912.11977796303298941853.b4-ty@oracle.com> (raw)
In-Reply-To: <20240415072155.30840-1-mrangankar@marvell.com>
On Mon, 15 Apr 2024 12:51:55 +0530, Manish Rangankar wrote:
> The qedi_dbg_do_not_recover_cmd_read() function invokes sprintf()
> directly on a __user pointer, which results into the crash.
>
> To fix this issue, use a small local stack buffer for sprintf() and then
> call simple_read_from_buffer(), which in turns make the copy_to_user()
> call.
>
> [...]
Applied to 6.10/scsi-queue, thanks!
[1/1] qedi: Fix crash while reading debugfs attribute.
https://git.kernel.org/mkp/scsi/c/28027ec8e32e
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-05-07 2:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 7:21 [PATCH v2] qedi: Fix crash while reading debugfs attribute Manish Rangankar
2024-04-25 1:09 ` Martin K. Petersen
2024-05-07 1:59 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171504445058.1494912.11977796303298941853.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=jmeneghi@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mhoyer@redhat.com \
--cc=mrangankar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).