From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Sathya Prakash Veerichetty <sathya.prakash@broadcom.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH v2] scsi: mpi3mr: Avoid memcpy field-spanning write WARNING
Date: Mon, 25 Mar 2024 21:21:46 -0400 [thread overview]
Message-ID: <171141606214.2006662.17226837967143528490.b4-ty@oracle.com> (raw)
In-Reply-To: <20240323084155.166835-1-shinichiro.kawasaki@wdc.com>
On Sat, 23 Mar 2024 17:41:55 +0900, Shin'ichiro Kawasaki wrote:
> When the "storcli2 show" command is executed for eHBA-9600, mpi3mr
> driver prints this WARNING message:
>
> memcpy: detected field-spanning write (size 128) of single field "bsg_reply_buf->reply_buf" at drivers/scsi/mpi3mr/mpi3mr_app.c:1658 (size 1)
> WARNING: CPU: 0 PID: 12760 at drivers/scsi/mpi3mr/mpi3mr_app.c:1658 mpi3mr_bsg_request+0x6b12/0x7f10 [mpi3mr]
>
> The cause of the WARN is 128 bytes memcpy to the 1 byte size array
> "__u8 replay_buf[1]" in the struct mpi3mr_bsg_in_reply_buf. The array is
> intended to be a flexible length array, then the WARN is a false
> positive. To suppress the WARN, remove the constant number '1' from the
> array declaration and clarify that it has flexible length. Also, adjust
> the memory allocation size to match the change.
>
> [...]
Applied to 6.9/scsi-fixes, thanks!
[1/1] scsi: mpi3mr: Avoid memcpy field-spanning write WARNING
https://git.kernel.org/mkp/scsi/c/429846b4b6ce
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2024-03-26 1:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 8:41 [PATCH v2] scsi: mpi3mr: Avoid memcpy field-spanning write WARNING Shin'ichiro Kawasaki
2024-03-26 1:21 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171141606214.2006662.17226837967143528490.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=johannes.thumshirn@wdc.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mpi3mr-linuxdrv.pdl@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).