From: Peter Griffin <peter.griffin@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: arnd@arndb.de, linux@roeck-us.net, wim@linux-watchdog.org,
alim.akhtar@samsung.com, jaewon02.kim@samsung.com,
semen.protsenko@linaro.org, alexey.klimov@linaro.org,
kernel-team@android.com, tudor.ambarus@linaro.org,
andre.draszik@linaro.org, saravanak@google.com,
willmcvicker@google.com, linux-fsd@tesla.com,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs
Date: Tue, 20 Feb 2024 10:43:27 +0000 [thread overview]
Message-ID: <CADrjBPp9A2eYbE+tRxfOe7MPaNa0uW+=6OzWbQeu2En=VoA0iA@mail.gmail.com> (raw)
In-Reply-To: <d25a887e-801d-410b-9ccd-2ec10fb28f23@linaro.org>
Hi Krzysztof,
On Tue, 20 Feb 2024 at 06:56, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 19/02/2024 20:47, Peter Griffin wrote:
> >>
> >>> +
> >>> + if (property)
> >>> + pmu_np = of_parse_phandle(np, property, 0);
> >>> + else
> >>> + pmu_np = np;
> >>> +
> >>> + if (!pmu_np)
> >>> + return ERR_PTR(-ENODEV);
> >>> +
> >>> + /*
> >>> + * Determine if exynos-pmu device has probed and therefore regmap
> >>> + * has been created and can be returned to the caller. Otherwise we
> >>> + * return -EPROBE_DEFER.
> >>> + */
> >>> + dev = driver_find_device_by_of_node(&exynos_pmu_driver.driver,
> >>> + (void *)pmu_np);
> >>> +
> >>> + of_node_put(pmu_np);
> >>
> >> You are dropping now referencen from np when property==NULL. This does
> >> no look right.
> >
> > Good spot, will fix. It seems syscon.c and altera-sysmgr also have the
> > same issue.
> >
>
> Do you plan on fixing them as well in such case?
Yes I'll send some patches to fix syscon and altera-sysmgr as well.
Thanks,
Peter
next prev parent reply other threads:[~2024-02-20 10:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:16 [PATCH v4 0/2] Add regmap support to exynos-pmu for protected PMU regs Peter Griffin
2024-02-08 16:16 ` [PATCH v4 1/2] soc: samsung: exynos-pmu: Add regmap support for SoCs that protect " Peter Griffin
2024-02-08 17:47 ` Sam Protsenko
2024-02-09 14:52 ` Alexey Klimov
2024-02-09 15:19 ` Peter Griffin
2024-02-09 20:50 ` Sam Protsenko
2024-02-15 18:36 ` Krzysztof Kozlowski
2024-02-19 19:47 ` Peter Griffin
2024-02-20 6:56 ` Krzysztof Kozlowski
2024-02-20 10:43 ` Peter Griffin [this message]
2024-02-08 16:17 ` [PATCH v4 2/2] watchdog: s3c2410_wdt: use exynos_get_pmu_regmap_by_phandle() for " Peter Griffin
2024-02-08 17:38 ` Guenter Roeck
2024-02-09 10:35 ` Alexey Klimov
2024-02-09 20:43 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADrjBPp9A2eYbE+tRxfOe7MPaNa0uW+=6OzWbQeu2En=VoA0iA@mail.gmail.com' \
--to=peter.griffin@linaro.org \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=jaewon02.kim@samsung.com \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=saravanak@google.com \
--cc=semen.protsenko@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).