From: Lukasz Luba <lukasz.luba@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org,
rafael@kernel.org, linux-pm@vger.kernel.org, nm@ti.com,
linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org,
viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org,
alim.akhtar@samsung.com, m.szyprowski@samsung.com,
mhiramat@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] Update Energy Model after chip binning adjusted voltages
Date: Wed, 3 Apr 2024 13:36:29 +0100 [thread overview]
Message-ID: <8519bb4c-e8b4-436c-bd3b-4a08e328a6ec@arm.com> (raw)
In-Reply-To: <045fa6db-4f76-46aa-85ba-c9e698c7e390@arm.com>
Hi Dietmar,
On 4/3/24 13:07, Dietmar Eggemann wrote:
> On 02/04/2024 17:58, Lukasz Luba wrote:
>> Hi all,
>>
>> This is a follow-up patch aiming to add EM modification due to chip binning.
>> The first RFC and the discussion can be found here [1].
>>
>> It uses Exynos chip driver code as a 1st user. The EM framework has been
>> extended to handle this use case easily, when the voltage has been changed
>> after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference.
>> According to that data in driver tables it could be up to ~29%.
>>
>> This chip binning is applicable to a lot of SoCs, so the EM framework should
>> make it easy to update. It uses the existing OPP and DT information to
>> re-calculate the new power values.
>>
>> It has dependency on Exynos SoC driver tree.
>>
>> Changes:
>> v4:
>> - added asterisk in the comment section (test robot)
>> - change the patch 2/4 header name and use 'Refactor'
>> v3:
>> - updated header description patch 2/4 (Dietmar)
>> - removed 2 sentences from comment and adjusted in patch 3/4 (Dietmar)
>> - patch 4/4 re-phrased code comment (Dietmar)
>> - collected tags (Krzysztof, Viresh)
>> v2:
>> - removed 'ret' from error message which wasn't initialized (Christian)
>> v1:
>> - exported the OPP calculation function from the OPP/OF so it can be
>> used from EM fwk (Viresh)
>> - refactored EM updating function to re-use common code
>> - added new EM function which can be used by chip device drivers which
>> modify the voltage in OPPs
>> RFC is at [1]
>>
>> Regards,
>> Lukasz Luba
>>
>> [1] https://lore.kernel.org/lkml/20231220110339.1065505-1-lukasz.luba@arm.com/
>>
>> Lukasz Luba (4):
>> OPP: OF: Export dev_opp_pm_calc_power() for usage from EM
>> PM: EM: Refactor em_adjust_new_capacity()
>> PM: EM: Add em_dev_update_chip_binning()
>> soc: samsung: exynos-asv: Update Energy Model after adjusting voltage
>>
>> drivers/opp/of.c | 17 +++--
>> drivers/soc/samsung/exynos-asv.c | 11 +++-
>> include/linux/energy_model.h | 5 ++
>> include/linux/pm_opp.h | 8 +++
>> kernel/power/energy_model.c | 106 +++++++++++++++++++++++++------
>> 5 files changed, 122 insertions(+), 25 deletions(-)
>
> LGTM.
>
> Just two very minor things which I mentioned in the individual patches.
>
> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
>
>
Thank you for the review. I will send the v5 with those.
Regards,
Lukasz
prev parent reply other threads:[~2024-04-03 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:58 [PATCH v4 0/4] Update Energy Model after chip binning adjusted voltages Lukasz Luba
2024-04-02 15:58 ` [PATCH v4 1/4] OPP: OF: Export dev_opp_pm_calc_power() for usage from EM Lukasz Luba
2024-04-03 12:07 ` Dietmar Eggemann
2024-04-02 15:58 ` [PATCH v4 2/4] PM: EM: Refactor em_adjust_new_capacity() Lukasz Luba
2024-04-02 15:58 ` [PATCH v4 3/4] PM: EM: Add em_dev_update_chip_binning() Lukasz Luba
2024-04-02 15:58 ` [PATCH v4 4/4] soc: samsung: exynos-asv: Update Energy Model after adjusting voltage Lukasz Luba
2024-04-03 12:07 ` Dietmar Eggemann
2024-04-03 12:07 ` [PATCH v4 0/4] Update Energy Model after chip binning adjusted voltages Dietmar Eggemann
2024-04-03 12:36 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8519bb4c-e8b4-436c-bd3b-4a08e328a6ec@arm.com \
--to=lukasz.luba@arm.com \
--cc=alim.akhtar@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mhiramat@kernel.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).