From: "André Draszik" <andre.draszik@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
peter.griffin@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
tudor.ambarus@linaro.org, willmcvicker@google.com,
semen.protsenko@linaro.org, alim.akhtar@samsung.com,
s.nawrocki@samsung.com, tomasz.figa@gmail.com,
cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential clocks as critical
Date: Thu, 01 Feb 2024 15:23:37 +0000 [thread overview]
Message-ID: <5d696d79d453c6b77f4ebc2d91256e4de6cd5ef5.camel@linaro.org> (raw)
In-Reply-To: <8dfab6a9-f9d1-46c2-8bd1-6ead4b26fbe1@linaro.org>
Hi Krzysztof,
On Thu, 2024-02-01 at 11:02 +0100, Krzysztof Kozlowski wrote:
> On 30/01/2024 10:36, André Draszik wrote:
> > The peric0_top1_ipclk_0 and peric0_top1_pclk_0 are the clocks going to
> > peric0/uart_usi, with pclk being the bus clock. Without pclk running,
> > any bus access will hang.
> > Unfortunately, in commit d97b6c902a40 ("arm64: dts: exynos: gs101:
> > update USI UART to use peric0 clocks") the gs101 DT ended up specifying
> > an incorrect pclk in the respective node and instead the two clocks
> > here were marked as critical.
> >
> > We have fixed the gs101 DT and can therefore drop this incorrect
> > work-around here, the uart driver will claim these clocks as needed.
>
> How did you fixed the DTS? Which commit did it? Are we going back to
> basics of driver changes depending on DTS?
Sorry if the description isn't clear.
a) these clocks are not critical for the system to work, and this patch fixes that.
b) the initial DTSI for gs101 used incorrect clocks for the serial, and it didn't
work. The work-around was to specify these clocks here as critical instead. Patch
#4 in this series has corrected the DTSI.
So there is no dependency between the DTS update and the driver update here as such,
no new properties, or otherwise.
That said, now that b) above has been fixed (in patch #4), it is OK to mark these
clocks as non-critical without any ill effects. That's all that is happening. I was
merely referencing that in the commit message.
I can rephrase things if you wish.
Cheers,
Andre'
next prev parent reply other threads:[~2024-02-01 15:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 9:36 [PATCH v2 0/6] gs101 oriole: peripheral block 0 (peric0) fixes André Draszik
2024-01-30 9:36 ` [PATCH v2 1/6] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on André Draszik
2024-02-01 9:58 ` Krzysztof Kozlowski
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 2/6] arm64: dts: exynos: gs101: fix usi8 default mode André Draszik
2024-02-01 10:16 ` Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 3/6] arm64: dts: exynos: gs101: use correct clocks for usi8 André Draszik
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 4/6] arm64: dts: exynos: gs101: use correct clocks for usi_uart André Draszik
2024-02-01 10:36 ` (subset) " Krzysztof Kozlowski
2024-01-30 9:36 ` [PATCH v2 5/6] clk: samsung: gs101: don't mark non-essential clocks as critical André Draszik
2024-02-01 10:02 ` Krzysztof Kozlowski
2024-02-01 15:23 ` André Draszik [this message]
2024-01-30 9:36 ` [PATCH v2 6/6] arm64: dts: exynos: gs101: reorder hsi2c_8 pinctrl-* properties André Draszik
2024-02-01 10:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d696d79d453c6b77f4ebc2d91256e4de6cd5ef5.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).