From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: alim.akhtar@samsung.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, andre.draszik@linaro.org,
willmcvicker@google.com, kernel-team@android.com
Subject: Re: [PATCH] arm64: dts: exynos: gs101: define all PERIC USI nodes
Date: Mon, 25 Mar 2024 09:22:59 +0100 [thread overview]
Message-ID: <3b38abb9-c3ac-4b55-889a-424396f1113d@linaro.org> (raw)
In-Reply-To: <73ba6104-aa54-444e-b6c5-7f89d1fa0060@linaro.org>
On 22/03/2024 14:39, Tudor Ambarus wrote:
>>
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>
> I'd like to respin this patch. Any preference on coding style for
> #address-cells and #size-cells? I guess they shall be above ranges
> property if present.
No, ranges should be just after reg, because it encodes often the same
or similar information (see also DTS Coding Style). I don't have
guideline, can be anywhere before vendor properties.
>
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&hsi2c1_bus>;
>>
>> Please reverse two lines, first pinctrl-0 then pinctrl-names. I know we
>
> Ok.
>
>> did not follow this convention till now, but at least new code can be
>> correct. Also clocks should be before pinctrl, so we keep some sort of
>> alphabetical order.
>
> Ok.
>
> I guess the order shall be:
>
> 1. compatible
> 2. reg
3. ranges
> 3. #address-cells (if applicable)
> #size-cells (if applicable)
> 5. Standard/common properties ordered alphabetically (ex. clocks,
> interrupts, pinctrl)
> 6. vendor-specific properties
> 7. status (if applicable)
>
Rest looks fine, thanks.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-03-25 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 13:59 [PATCH] arm64: dts: exynos: gs101: define all PERIC USI nodes Tudor Ambarus
2024-03-08 16:45 ` Krzysztof Kozlowski
2024-03-11 10:47 ` Peter Griffin
2024-03-22 13:39 ` Tudor Ambarus
2024-03-25 8:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b38abb9-c3ac-4b55-889a-424396f1113d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).