From: "Ricardo B. Marliere" <ricardo@marliere.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] ARM: s3c64xx: make s3c6410_subsys const
Date: Mon, 12 Feb 2024 08:35:14 -0300 [thread overview]
Message-ID: <2ezdr4px2tfzpn7ut63wdtmcb2roid4d6kpl654wwmfvkemhpq@k5hpjz74q4ho> (raw)
In-Reply-To: <b7726526-0b0a-4d3d-bf05-b1065d361cc2@linaro.org>
Hi Krzysztof,
On 12 Feb 08:31, Krzysztof Kozlowski wrote:
> On 11/02/2024 16:57, Ricardo B. Marliere wrote:
> > Since commit d492cc2573a0 ("driver core: device.h: make struct bus_type
> > a const *"), the driver core can properly handle constant struct
> > bus_type, move the s3c6410_subsys variable to be a constant structure as
> > well, placing it into read-only memory which can not be modified at
> > runtime.
> >
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> > ---
>
> I just noticed you sent quite the same change for the same subarch.
> Please perform changes all at once. Squashed.
Yes, sorry about that. The reason for this is that I initially started
splitting up this commit into proper submissions:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=bus_cleanup&id=26105f537f0c60eacfeb430abd2e05d7ddcdd8aa
And only after that I started grepping the tree for the other users.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-02-12 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 15:57 [PATCH v2] ARM: s3c64xx: make s3c6410_subsys const Ricardo B. Marliere
2024-02-12 7:31 ` Krzysztof Kozlowski
2024-02-12 11:35 ` Ricardo B. Marliere [this message]
2024-02-12 8:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ezdr4px2tfzpn7ut63wdtmcb2roid4d6kpl654wwmfvkemhpq@k5hpjz74q4ho \
--to=ricardo@marliere.net \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).