From: Stephen Boyd <sboyd@kernel.org>
To: 'Dan Carpenter' <dan.carpenter@linaro.org>,
Shradha Todi <shradha.t@samsung.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com,
jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com,
robh@kernel.org, bhelgaas@google.com,
krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
linux@armlinux.org.uk, m.szyprowski@samsung.com,
manivannan.sadhasivam@linaro.org, pankaj.dubey@samsung.com,
gost.dev@samsung.com
Subject: RE: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk clocks
Date: Fri, 15 Mar 2024 10:39:41 -0700 [thread overview]
Message-ID: <2688272d2763a36f401a08ca48c0eb24.sboyd@kernel.org> (raw)
In-Reply-To: <104401da76cc$ccc772c0$66565840$@samsung.com>
Quoting Shradha Todi (2024-03-15 04:34:44)
> >
> > Quoting Shradha Todi (2024-03-06 04:13:03)
> > > >
> > > > When clk_bulk_get_all() returns zero then we return success here.
> > > >
> > >
> > > Yes, we are returning success in case there are no clocks as well. In
> > > case there are no clocks defined in the DT-node, then it is assumed
> > > that the driver does not need any clock manipulation for driver
> > > operation. So the intention here is to continue without throwing
> > > error.
> >
> > Maybe we shouldn't even return the clks to the caller. Do you have any use for
> > the clk pointers?
>
> The intention to return the clk pointers was in the case where caller wants to
> manipulate a particular clock in certain conditions. They can obtain the clock pointer
> and use clk_set_parent, clk_set_rate on those particular clocks.
> But I understand that in that case users can use existing clk_bulk_get_all() API.
> So, should I go ahead and send v7?
>
No, I think this is fine.
next prev parent reply other threads:[~2024-03-15 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240220084109epcas5p3dc6b95a0ed69b63e93f4aa0a6fc919fe@epcas5p3.samsung.com>
2024-02-20 8:40 ` [PATCH v6 0/2] Add helper function to get and enable all bulk clocks Shradha Todi
[not found] ` <CGME20240220084120epcas5p1e8980539667c3d9da20f49fc645d8f4c@epcas5p1.samsung.com>
2024-02-20 8:40 ` [PATCH v6 1/2] clk: Provide managed helper to get and enable " Shradha Todi
2024-02-22 5:15 ` Stephen Boyd
2024-03-05 8:50 ` Dan Carpenter
2024-03-06 12:13 ` Shradha Todi
2024-03-09 0:50 ` Stephen Boyd
2024-03-15 11:34 ` Shradha Todi
2024-03-15 17:39 ` Stephen Boyd [this message]
[not found] ` <CGME20240220084125epcas5p28c6d886685006800fc26c11918d5d1dd@epcas5p2.samsung.com>
2024-02-20 8:40 ` [PATCH v6 2/2] PCI: exynos: Adapt to clk_bulk_* APIs Shradha Todi
2024-05-17 11:25 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2688272d2763a36f401a08ca48c0eb24.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@linaro.org \
--cc=gost.dev@samsung.com \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mturquette@baylibre.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh@kernel.org \
--cc=shradha.t@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).