From: Jonathan Cameron <jic23@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-iio@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 0/8] iio: use 'time_left' instead of 'timeout' with wait_for_*() functions
Date: Mon, 29 Apr 2024 21:06:48 +0100 [thread overview]
Message-ID: <20240429210648.4b429d31@jic23-huawei> (raw)
In-Reply-To: <20240429113313.68359-1-wsa+renesas@sang-engineering.com>
On Mon, 29 Apr 2024 13:33:03 +0200
Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeout' to
> store the result of wait_for_*() functions causing patterns like:
>
> timeout = wait_for_completion_timeout(...)
> if (!timeout) return -ETIMEDOUT;
>
> with all kinds of permutations. Use 'time_left' as a variable to make the code
> obvious and self explaining.
>
> This is part of a tree-wide series. The rest of the patches can be found here
> (some parts may still be WIP):
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/time_left
>
> Because these patches are generated, I audit them before sending. This is why I
> will send series step by step. Build bot is happy with these patches, though.
> No functional changes intended.
Nice improvement. Applied
>
> Wolfram Sang (8):
> iio: adc: ad_sigma_delta: use 'time_left' variable with
> wait_for_completion_timeout()
> iio: adc: exynos_adc: use 'time_left' variable with
> wait_for_completion_timeout()
> iio: adc: fsl-imx25-gcq: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
> iio: adc: intel_mrfld_adc: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
> iio: adc: stm32-adc: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
> iio: adc: stm32-dfsdm-adc: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
> iio: adc: twl6030-gpadc: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
> iio: pressure: zpa2326: use 'time_left' variable with
> wait_for_completion_interruptible_timeout()
>
> drivers/iio/adc/ad_sigma_delta.c | 6 +++---
> drivers/iio/adc/exynos_adc.c | 16 ++++++++--------
> drivers/iio/adc/fsl-imx25-gcq.c | 10 +++++-----
> drivers/iio/adc/intel_mrfld_adc.c | 12 ++++++------
> drivers/iio/adc/stm32-adc.c | 10 +++++-----
> drivers/iio/adc/stm32-dfsdm-adc.c | 12 ++++++------
> drivers/iio/adc/twl6030-gpadc.c | 8 ++++----
> drivers/iio/pressure/zpa2326.c | 10 +++++-----
> 8 files changed, 42 insertions(+), 42 deletions(-)
>
prev parent reply other threads:[~2024-04-29 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 11:33 [PATCH 0/8] iio: use 'time_left' instead of 'timeout' with wait_for_*() functions Wolfram Sang
2024-04-29 11:33 ` [PATCH 2/8] iio: adc: exynos_adc: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-04-29 20:06 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429210648.4b429d31@jic23-huawei \
--to=jic23@kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).