From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Johan Hovold <johan@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/5] usb: dwc3: exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions
Date: Tue, 16 Apr 2024 00:44:05 +0000 [thread overview]
Message-ID: <20240416003145.izkwh5kc5sqy4irf@synopsys.com> (raw)
In-Reply-To: <20240412142317.5191-6-linux.amoon@gmail.com>
On Fri, Apr 12, 2024, Anand Moon wrote:
> This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
> care about when the functions are actually used.
>
> Also make use of pm_sleep_ptr() to discard all PM_SLEEP related
> stuff if CONFIG_PM_SLEEP isn't enabled.
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v3: fix using new DEFINE_SIMPLE_DEV_PM_OPS PM macro hence
> change the $subject and the commit message
>
> v2: add __maybe_unused to suspend/resume functions in case CONFIG_PM
> is disabled.
> ---
> drivers/usb/dwc3/dwc3-exynos.c | 13 +++----------
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 5d365ca51771..3427522a7c6a 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -187,7 +187,6 @@ static const struct of_device_id exynos_dwc3_match[] = {
> };
> MODULE_DEVICE_TABLE(of, exynos_dwc3_match);
>
> -#ifdef CONFIG_PM_SLEEP
> static int dwc3_exynos_suspend(struct device *dev)
> {
> struct dwc3_exynos *exynos = dev_get_drvdata(dev);
> @@ -230,14 +229,8 @@ static int dwc3_exynos_resume(struct device *dev)
> return 0;
> }
>
> -static const struct dev_pm_ops dwc3_exynos_dev_pm_ops = {
> - SET_SYSTEM_SLEEP_PM_OPS(dwc3_exynos_suspend, dwc3_exynos_resume)
> -};
> -
> -#define DEV_PM_OPS (&dwc3_exynos_dev_pm_ops)
> -#else
> -#define DEV_PM_OPS NULL
> -#endif /* CONFIG_PM_SLEEP */
> +static DEFINE_SIMPLE_DEV_PM_OPS(dwc3_exynos_dev_pm_ops,
> + dwc3_exynos_suspend, dwc3_exynos_resume);
>
> static struct platform_driver dwc3_exynos_driver = {
> .probe = dwc3_exynos_probe,
> @@ -245,7 +238,7 @@ static struct platform_driver dwc3_exynos_driver = {
> .driver = {
> .name = "exynos-dwc3",
> .of_match_table = exynos_dwc3_match,
> - .pm = DEV_PM_OPS,
> + .pm = pm_sleep_ptr(&dwc3_exynos_dev_pm_ops),
> },
> };
>
> --
> 2.44.0
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
prev parent reply other threads:[~2024-04-16 0:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240412142317.5191-1-linux.amoon@gmail.com>
2024-04-12 14:22 ` [PATCH v3 1/5] usb: ehci-exynos: Use devm_clk_get_enabled() helpers Anand Moon
2024-04-12 14:58 ` Alan Stern
2024-04-12 14:22 ` [PATCH v3 2/5] usb: ehci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Anand Moon
2024-04-12 14:22 ` [PATCH v3 3/5] usb: ohci-exynos: Use devm_clk_get_enabled() helpers Anand Moon
2024-04-12 14:22 ` [PATCH v3 4/5] usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions Anand Moon
2024-04-12 14:22 ` [PATCH v3 5/5] usb: dwc3: exynos: " Anand Moon
2024-04-16 0:44 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416003145.izkwh5kc5sqy4irf@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=alim.akhtar@samsung.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux.amoon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).