From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
<linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@axis.com>
Subject: Re: [PATCH] i2c: exynos5: Init data before registering interrupt handler
Date: Mon, 4 Mar 2024 17:17:18 +0100 [thread overview]
Message-ID: <20240304161718.GT30969@axis.com> (raw)
In-Reply-To: <1f4a2ada-0867-4ee0-bf27-4d69ab85b2e4@linaro.org>
On Mon, Mar 04, 2024 at 04:08:00PM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2024 16:04, Andi Shyti wrote:
> >> -
> >> i2c->variant = of_device_get_match_data(&pdev->dev);
> >> + if (!i2c->variant) {
> >> + dev_err(&pdev->dev, "can't match device variant\n");
> >> + return -ENODEV;
> >
> > return dev_err_probe(), please.
>
> How this condition even possibly happen? And how is this related to the
> problem described here?
No, it was not. That was part of the debugging before we understood
the real problem.
> No, don't mix two different issues.
No problem, I can drop this part.
> Best regards,
> Krzysztof
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2024-03-04 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 11:01 [PATCH] i2c: exynos5: Init data before registering interrupt handler Jesper Nilsson
2024-03-04 15:04 ` Andi Shyti
2024-03-04 15:08 ` Krzysztof Kozlowski
2024-03-04 16:17 ` Jesper Nilsson [this message]
2024-03-04 16:15 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240304161718.GT30969@axis.com \
--to=jesper.nilsson@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).