From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
"\"Uwe Kleine-König\"" <u.kleine-koenig@pengutronix.de>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Alexey Brodkin" <abrodkin@synopsys.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Biju Das" <biju.das.jz@bp.renesas.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"David Airlie" <airlied@gmail.com>,
"Eugen Hristev" <eugen.hristev@collabora.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
"Helge Deller" <deller@gmx.de>,
"Hugues Fruchet" <hugues.fruchet@foss.st.com>,
"Jacopo Mondi" <jacopo@jmondi.org>,
"Jessica Zhang" <quic_jesszhan@quicinc.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Russell King" <linux@armlinux.org.uk>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tim Harvey" <tharvey@gateworks.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org,
linux-omap@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH 3/4] media: platform: replace of_graph_get_next_endpoint()
Date: Wed, 7 Feb 2024 15:57:37 +0200 [thread overview]
Message-ID: <20240207135737.GI2827@pendragon.ideasonboard.com> (raw)
In-Reply-To: <875xz1tave.wl-kuninori.morimoto.gx@renesas.com>
On Tue, Feb 06, 2024 at 11:45:58PM +0000, Kuninori Morimoto wrote:
>
> Hi Laurent
>
> Thank you for your review
>
> > > diff --git a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > > index 686ca8753ba2..3f8bea2e3934 100644
> > > --- a/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > > +++ b/drivers/media/platform/samsung/exynos4-is/mipi-csis.c
> > > @@ -728,7 +728,7 @@ static int s5pcsis_parse_dt(struct platform_device *pdev,
> > > &state->max_num_lanes))
> > > return -EINVAL;
> > >
> > > - node = of_graph_get_next_endpoint(node, NULL);
> > > + node = of_graph_get_endpoint_by_regs(node, 0, -1);
> >
> > This is not correct, see
> > Documentation/devicetree/bindings/media/samsung,exynos4210-csis.yaml.
>
> Hmm... Then, It can be like this ?
>
> + node = of_graph_get_endpoint_by_regs(node, -1, -1);
I suppose that would work, even if we should really try not to pass -1
for the port. Rob, any opinion ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-02-07 13:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 2:54 [PATCH 0/4] of: replace of_graph_get_next_endpoint() Kuninori Morimoto
2024-02-06 2:55 ` [PATCH 1/4] gpu: drm: " Kuninori Morimoto
2024-02-06 13:31 ` Laurent Pinchart
2024-02-06 2:55 ` [PATCH 2/4] media: i2c: " Kuninori Morimoto
2024-02-06 13:41 ` Laurent Pinchart
2024-02-06 14:44 ` Hans Verkuil
2024-02-07 1:06 ` Kuninori Morimoto
2024-02-07 13:14 ` Krzysztof Hałasa
2024-02-07 13:51 ` Laurent Pinchart
2024-02-07 13:54 ` Hans Verkuil
2024-02-07 13:13 ` Krzysztof Hałasa
2024-02-07 13:55 ` Laurent Pinchart
2024-02-06 2:55 ` [PATCH 3/4] media: platform: " Kuninori Morimoto
2024-02-06 16:25 ` Laurent Pinchart
2024-02-06 23:45 ` Kuninori Morimoto
2024-02-07 13:57 ` Laurent Pinchart [this message]
2024-02-06 2:55 ` [PATCH 4/4] video: fbdev: " Kuninori Morimoto
2024-02-06 16:44 ` Laurent Pinchart
2024-02-07 0:05 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207135737.GI2827@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=abrodkin@synopsys.com \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel@ffwll.ch \
--cc=dave.stevenson@raspberrypi.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=eugen.hristev@collabora.com \
--cc=florian.fainelli@broadcom.com \
--cc=hugues.fruchet@foss.st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=prabhakar.csengg@gmail.com \
--cc=quic_jesszhan@quicinc.com \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sam@ravnborg.org \
--cc=tharvey@gateworks.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).