From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: broonie@kernel.org, andi.shyti@kernel.org, semen.protsenko@linaro.org
Cc: krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com,
jassi.brar@samsung.com, linux-spi@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andre.draszik@linaro.org,
peter.griffin@linaro.org, kernel-team@android.com,
willmcvicker@google.com, Tudor Ambarus <tudor.ambarus@linaro.org>
Subject: [PATCH v3 00/17] spi: s3c64xx: straightforward cleanup
Date: Fri, 26 Jan 2024 17:15:28 +0000 [thread overview]
Message-ID: <20240126171546.1233172-1-tudor.ambarus@linaro.org> (raw)
Straightforward patches that clean the driver. Just compiled tested.
Stands up just the patch that updates the driver to use the bitfield
access macros. The bit operations shall be identical after the patch.
Sam and Andi have some concerns on whether using the bitfield access
macros are just a matter of taste, or they are actually necessary.
I think they are necessary. Here are the concerns/discussions:
https://lore.kernel.org/linux-arm-kernel/ee4107c3-1141-45ab-874c-03474d8ec18d@linaro.org/
https://lore.kernel.org/linux-arm-kernel/ri7gerw4ov4jnmmkhtumhhtgfgxtr6kpsopdxjlx6fylbqznna@3qgvejyhjirw/
Cheers,
ta
v3:
- reworked the bitfied access macros patch so that the bit operations
are the same as before the patch. Fix S3C64XX_SPI_PSR_MASK value,
drop S3C64XX_SPI_CS_NSC_CNT_MASK.
- add a new patches to explicitly remove a duplicated definition and to
drop a superfluous bitwise NOT operation.
- collect R-b tags
v2:
https://lore.kernel.org/linux-arm-kernel/36a664b1-666d-4fc4-90d9-35b42e56973d@linaro.org/
Tudor Ambarus (17):
spi: s3c64xx: explicitly include <linux/io.h>
spi: s3c64xx: explicitly include <linux/bits.h>
spi: s3c64xx: avoid possible negative array index
spi: s3c64xx: fix typo, s/configuartion/configuration
spi: s3c64xx: sort headers alphabetically
spi: s3c64xx: remove unneeded (void *) casts in of_match_table
spi: s3c64xx: remove else after return
spi: s3c64xx: move common code outside if else
spi: s3c64xx: check return code of dmaengine_slave_config()
spi: s3c64xx: propagate the dma_submit_error() error code
spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma()
spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout()
spi: s3c64xx: drop blank line between declarations
spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props
spi: s3c64xx: remove duplicated definition
spi: s3c64xx: drop a superfluous bitwise NOT operation
spi: s3c64xx: use bitfield access macros
drivers/spi/spi-s3c64xx.c | 298 ++++++++++++++++++++------------------
1 file changed, 158 insertions(+), 140 deletions(-)
--
2.43.0.429.g432eaa2c6b-goog
next reply other threads:[~2024-01-26 17:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 17:15 Tudor Ambarus [this message]
2024-01-26 17:15 ` [PATCH v3 01/17] spi: s3c64xx: explicitly include <linux/io.h> Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 02/17] spi: s3c64xx: explicitly include <linux/bits.h> Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 03/17] spi: s3c64xx: avoid possible negative array index Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 04/17] spi: s3c64xx: fix typo, s/configuartion/configuration Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 05/17] spi: s3c64xx: sort headers alphabetically Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 06/17] spi: s3c64xx: remove unneeded (void *) casts in of_match_table Tudor Ambarus
2024-01-26 20:17 ` Sam Protsenko
2024-01-27 3:41 ` Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 07/17] spi: s3c64xx: remove else after return Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 08/17] spi: s3c64xx: move common code outside if else Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 09/17] spi: s3c64xx: check return code of dmaengine_slave_config() Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 10/17] spi: s3c64xx: propagate the dma_submit_error() error code Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 11/17] spi: s3c64xx: rename prepare_dma() to s3c64xx_prepare_dma() Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 12/17] spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout() Tudor Ambarus
2024-01-26 20:13 ` Sam Protsenko
2024-01-27 3:26 ` Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 13/17] spi: s3c64xx: drop blank line between declarations Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 14/17] spi: s3c64xx: downgrade dev_warn to dev_dbg for optional dt props Tudor Ambarus
2024-01-26 17:15 ` [PATCH v3 15/17] spi: s3c64xx: remove duplicated definition Tudor Ambarus
2024-01-26 20:06 ` Sam Protsenko
2024-01-26 17:15 ` [PATCH v3 16/17] spi: s3c64xx: drop a superfluous bitwise NOT operation Tudor Ambarus
2024-01-26 20:09 ` Sam Protsenko
2024-01-26 17:15 ` [PATCH v3 17/17] spi: s3c64xx: use bitfield access macros Tudor Ambarus
2024-01-26 20:12 ` Sam Protsenko
2024-01-27 3:23 ` Tudor Ambarus
2024-01-27 3:38 ` Sam Protsenko
2024-01-27 3:44 ` Tudor Ambarus
2024-01-29 16:42 ` Mark Brown
2024-01-29 17:59 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126171546.1233172-1-tudor.ambarus@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=jassi.brar@samsung.com \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=semen.protsenko@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).