From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: krzysztof.kozlowski+dt@linaro.org, broonie@kernel.org
Cc: robh+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, andre.draszik@linaro.org,
peter.griffin@linaro.org, semen.protsenko@linaro.org,
kernel-team@android.com, willmcvicker@google.com,
Tudor Ambarus <tudor.ambarus@linaro.org>
Subject: [PATCH 0/7] ARM: dts: samsung: specify the SPI fifosize
Date: Thu, 25 Jan 2024 15:16:23 +0000 [thread overview]
Message-ID: <20240125151630.753318-1-tudor.ambarus@linaro.org> (raw)
Hi,
The "samsung,spi-fifosize" was introduced in the following patch set:
https://lore.kernel.org/linux-arm-kernel/20240125145007.748295-1-tudor.ambarus@linaro.org/T/#t
I expect Mark will provide an immutable tag for the bindings so that it
can be merged into the samsung tree. We'll avoid this way using the
property into the device trees without having it defined into the
bindings.
These patches close the circle and break the dependency between the SPI
of_alias ID and the SPI driver. The SPI of_alias ID was used as an index
into the fifo_lvl_mask to determine the FIFO depth of the SPI node.
Changing the alias ID into the device tree would make the driver choose
a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask
array boundaries. Not specifying an SPI alias would make the driver fail
to probe, which was wrong too. Thus I updated the driver and I provided
alternatives to either infer the FIFO size from the compatible, where
the SoC uses the same FIFO size for all the instances of the IP, or by
using the "samsung,spi-fifosize" dt property, where the SoC uses
different FIFO sizes for the instances of the IP. This patch set takes
care of the second case and adds "samsung,spi-fifosize" for all the SoCs
that need it.
Cheers,
ta
Tudor Ambarus (7):
ARM: dts: samsung: s5pv210: specify the SPI fifosize
ARM: dts: samsung: exynos3250: specify the SPI fifosize
ARM: dts: samsung: exynos4: specify the SPI fifosize
ARM: dts: samsung: exynos5250: specify the SPI fifosize
ARM: dts: samsung: exynos5450: specify the SPI fifosize
ARM: dts: samsung: exynos5433: specify the SPI fifosize
ARM: dts: samsung: exynosautov9: specify the SPI fifosize
arch/arm/boot/dts/samsung/exynos3250.dtsi | 2 ++
arch/arm/boot/dts/samsung/exynos4.dtsi | 3 +++
arch/arm/boot/dts/samsung/exynos5250.dtsi | 3 +++
arch/arm/boot/dts/samsung/exynos5420.dtsi | 3 +++
arch/arm/boot/dts/samsung/s5pv210.dtsi | 2 ++
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 5 +++++
arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 12 ++++++++++++
7 files changed, 30 insertions(+)
--
2.43.0.429.g432eaa2c6b-goog
next reply other threads:[~2024-01-25 15:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 15:16 Tudor Ambarus [this message]
2024-01-25 15:16 ` [PATCH 1/7] ARM: dts: samsung: s5pv210: specify the SPI fifosize Tudor Ambarus
2024-01-25 15:16 ` [PATCH 2/7] ARM: dts: samsung: exynos3250: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 3/7] ARM: dts: samsung: exynos4: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 4/7] ARM: dts: samsung: exynos5250: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 5/7] ARM: dts: samsung: exynos5450: " Tudor Ambarus
2024-01-30 17:08 ` Henrik Grimler
2024-01-25 15:16 ` [PATCH 6/7] ARM: dts: samsung: exynos5433: " Tudor Ambarus
2024-01-25 15:16 ` [PATCH 7/7] ARM: dts: samsung: exynosautov9: " Tudor Ambarus
2024-01-25 15:53 ` [PATCH 0/7] ARM: dts: samsung: " Mark Brown
2024-01-25 15:56 ` Krzysztof Kozlowski
2024-02-01 10:33 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125151630.753318-1-tudor.ambarus@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).