Linux-Safety Archive mirror
 help / color / mirror / Atom feed
From: "Milan Lakhani" <milan.lakhani@codethink.co.uk>
To: linux-kernel@vger.kernel.org, linux-safety@lists.elisa.tech
Cc: Milan Lakhani <milan.lakhani@codethink.co.uk>
Subject: [linux-safety] [PATCH] kernel: trace: Remove deadstore in trace_uprobe.c
Date: Wed,  9 Dec 2020 13:16:54 +0000	[thread overview]
Message-ID: <1607519814-86271-1-git-send-email-milan.lakhani@codethink.co.uk> (raw)
In-Reply-To: <devel@driverdev.osuosl.org, rostedt@goodmis.org, mingo@redhat.com, gregkh@linuxfoundation.org>

In trace_uprobe.c, trace_uprobe_create assigns ret to 0 but then never
uses this value.

Signed-off-by: Milan Lakhani <milan.lakhani@codethink.co.uk>
---
 kernel/trace/trace_uprobe.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 3cf7128..c7c7070 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -541,7 +541,6 @@ static int trace_uprobe_create(int argc, const char **argv)
 	bool is_return = false;
 	int i, ret;
 
-	ret = 0;
 	ref_ctr_offset = 0;
 
 	switch (argv[0][0]) {
-- 
2.7.4



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#217): https://lists.elisa.tech/g/linux-safety/message/217
Mute This Topic: https://lists.elisa.tech/mt/78828451/5278000
Group Owner: linux-safety+owner@lists.elisa.tech
Unsubscribe: https://lists.elisa.tech/g/linux-safety/unsub [linux-safety@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-



       reply	other threads:[~2020-12-09 13:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <devel@driverdev.osuosl.org, rostedt@goodmis.org, mingo@redhat.com, gregkh@linuxfoundation.org>
2020-12-09 13:16 ` Milan Lakhani [this message]
2020-12-10  5:47   ` [linux-safety] [PATCH] kernel: trace: Remove deadstore in trace_uprobe.c Lukas Bulwahn
2020-12-10 11:29     ` Milan Lakhani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1607519814-86271-1-git-send-email-milan.lakhani@codethink.co.uk \
    --to=milan.lakhani@codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-safety@lists.elisa.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).