From: Baoquan He <bhe@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, linux-mips@vger.kernel.org,
linux-riscv@lists.infradead.org, loongarch@lists.linux.dev,
akpm@linux-foundation.org, ebiederm@xmission.com,
hbathini@linux.ibm.com, piliu@redhat.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting code out from crash_core.c
Date: Mon, 25 Mar 2024 17:48:18 +0800 [thread overview]
Message-ID: <ZgFIYuYULrgF1tFG@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAMuHMdVxKEGYj9C1=P-493vcrN_HmLNx8gS6i1nheXO9gH46oA@mail.gmail.com>
On 03/25/24 at 09:24am, Geert Uytterhoeven wrote:
> Hi Baoquan,
>
> On Wed, Jan 24, 2024 at 6:13 AM Baoquan He <bhe@redhat.com> wrote:
> > Now move the relevant codes into separate files:
> > kernel/crash_reserve.c, include/linux/crash_reserve.h.
> >
> > And add config item CRASH_RESERVE to control its enabling.
> >
> > And also update the old ifdeffery of CONFIG_CRASH_CORE, including of
> > <linux/crash_core.h> and config item dependency on CRASH_CORE
> > accordingly.
> >
> > And also do renaming as follows:
> > - arch/xxx/kernel/{crash_core.c => vmcore_info.c}
> > because they are only related to vmcoreinfo exporting on x86, arm64,
> > riscv.
> >
> > And also Remove config item CRASH_CORE, and rely on CONFIG_KEXEC_CORE to
> > decide if build in crash_core.c.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > v2->v3:
> > - There's conflict when rebasing to linux-next in kernel/crash_core.c
> > because of below commits from Uladzislau:
> > commit 699d9351822e ("mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init()")
> > commit 5f4c0c1e2a51 (:mm/vmalloc: remove vmap_area_list")
>
> Thanks for your patch, which is now commit 443cbaf9e2fdbef7
> ("crash: split vmcoreinfo exporting code out from
> crash_core.c") in v6.9-rc1.
>
> After this, there are still two references left to CRASH_CORE:
>
> 1. Documentation/admin-guide/kdump/kdump.rst:
>
> Subsequently, CRASH_CORE is selected by KEXEC_CORE::
>
> 2. arch/loongarch/Kconfig
>
> config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
> def_bool CRASH_CORE
Sure, will post patch to clean them up. Thanks a lot.
next prev parent reply other threads:[~2024-03-25 9:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 5:12 [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 01/14] kexec: split crashkernel reservation code out from crash_core.c Baoquan He
2024-01-28 1:28 ` Klara Modin
2024-01-29 1:57 ` Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting " Baoquan He
2024-03-25 8:24 ` Geert Uytterhoeven
2024-03-25 9:48 ` Baoquan He [this message]
2024-01-24 5:12 ` [PATCH linux-next v3 03/14] crash: remove dependency of FA_DUMP on CRASH_DUMP Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 04/14] crash: split crash dumping code out from kexec_core.c Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 05/14] crash: clean up kdump related config items Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 06/14] x86, crash: wrap crash dumping code into crash related ifdefs Baoquan He
2024-01-24 23:02 ` Michael Kelley
2024-01-25 4:09 ` Baoquan He
2024-01-25 5:12 ` Michael Kelley
2024-01-25 9:17 ` Baoquan He
2024-01-25 15:30 ` Michael Kelley
2024-01-24 5:12 ` [PATCH linux-next v3 07/14] arm64, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 08/14] ppc, crash: enforce KEXEC and KEXEC_FILE to select CRASH_DUMP Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 09/14] s390, crash: wrap crash dumping code into crash related ifdefs Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 10/14] sh, " Baoquan He
2024-01-24 8:13 ` John Paul Adrian Glaubitz
2024-01-24 14:38 ` Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 11/14] mips, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 12/14] riscv, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 13/14] arm, " Baoquan He
2024-01-24 5:12 ` [PATCH linux-next v3 14/14] loongarch, " Baoquan He
2024-01-26 4:55 ` [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items Nathan Chancellor
2024-01-26 6:07 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZgFIYuYULrgF1tFG@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=geert@linux-m68k.org \
--cc=hbathini@linux.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=piliu@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).