From: Jialong Yang <jialong.yang@shingroup.cn>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/s390/perf: Register cpumf_pmu with type = PERF_TYPE_RAW
Date: Tue, 5 Mar 2024 22:16:13 +0800 [thread overview]
Message-ID: <C179F8ADAF657FB4+0d190e88-02b6-49a4-96bd-844e470b4605@shingroup.cn> (raw)
In-Reply-To: <ZecStMBA4YgQaBEZ@FVFF77S0Q05N>
在 2024/3/5 20:40, Mark Rutland 写道:
> On Tue, Mar 05, 2024 at 09:43:16AM +0800, Yang Jialong 杨佳龙 wrote:
>> 在 2024/3/4 17:34, Mark Rutland 写道:
>>> On Mon, Mar 04, 2024 at 10:27:01AM +0800, JiaLong.Yang wrote:
>>>> The struct pmu cpumf_pmu has handled generic events. So it need some
>>>> flags to tell core this thing.
>>> It's not necessary to register as PERF_TYPE_RAW in order to handle raw events,
>>> and PERF_TYPE_RAW is not a flag.
>>>
>>> Have you encountered a functional problem, or was this found by inspection?
>> As you expected, I'm trying to confirm which one pmu has the capability to
>> handle generic events in registering pmus instead of test generic events in
>> each pmus when opening.
> If we want to do that, then we need a new flag on struct pmu to restrict which
> events we try to open on a PMU.
>
> If you want to do that, you need to Cc the perf maintainers and discuss that
> rather than point-hacking individual drivers.
>
>> We can confirm that before using. We have pay more in handling them when
>> opening.
>> So most driver developers use PERF_TYPE_RAW. x86 and arm use
>> PERF_PMU_CAP_EXTENDED_HW_TYPE. Others use struct pmu::task_ctx_nr =
>> perf_hw_context.
>> I think PERF_TYPE_RAW will be a easily accepted way. So ...
> No, this is a hack, and it doesn't solve the problem you describe above.
>
> If we want to remove the need for most PMUs to look at perf_event_attr::type,
> then we should have a new PERF_PMU_CAP_ flag on the PMU to say "this PMU
> supports generic events" (or separate flags for the generic RAW/HW/CACHE
> types), and update all relevant PMUs accordingly.
>
> Please do not try to overload pmu::type with additional semantics; it's messy
> enough as-is.
OK. Thanks for guiding.
>
> Mark.
>
prev parent reply other threads:[~2024-03-05 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 2:27 [PATCH] arch/s390/perf: Register cpumf_pmu with type = PERF_TYPE_RAW JiaLong.Yang
2024-03-04 9:34 ` Mark Rutland
2024-03-05 1:43 ` Yang Jialong 杨佳龙
2024-03-05 12:40 ` Mark Rutland
2024-03-05 14:16 ` Jialong Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C179F8ADAF657FB4+0d190e88-02b6-49a4-96bd-844e470b4605@shingroup.cn \
--to=jialong.yang@shingroup.cn \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).