From: Thomas Huth <thuth@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>,
Nico Boehr <nrb@linux.ibm.com>,
frankja@linux.ibm.com, imbrenda@linux.ibm.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v1] arch-run: Wait for incoming socket being removed
Date: Tue, 12 Mar 2024 07:45:40 +0100 [thread overview]
Message-ID: <4a2354b7-df7b-4371-a4fa-d1da29ae4dd3@redhat.com> (raw)
In-Reply-To: <CZRKBTZFFB9Y.38GVXEXZPOVK5@wheely>
On 12/03/2024 07.37, Nicholas Piggin wrote:
> On Wed Mar 6, 2024 at 12:11 AM AEST, Nico Boehr wrote:
>> Sometimes, QEMU needs a bit longer to remove the incoming migration
>> socket. This happens in some environments on s390x for the
>> migration-skey-sequential test.
>>
>> Instead of directly erroring out, wait for the removal of the socket.
>>
>> Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
>
> It's interesting that the incoming socket is not removed after
> QMP says migration complete. I guess that's by design, but have
> you checked the QEMU code whether it's intentional?
>
> I guess it's code like this - in migration/migration.c
>
> /*
> * This must happen after any state changes since as soon as an external
> * observer sees this event they might start to prod at the VM assuming
> * it's ready to use.
> */
> migrate_set_state(&mis->state, MIGRATION_STATUS_ACTIVE,
> MIGRATION_STATUS_COMPLETED);
> migration_incoming_state_destroy();
>
> So, it looks like a good fix. And probably not just s390x specific
> it might be just unlucky timing.
>
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
All right, I pushed this as a fix now to the repository.
Thomas
prev parent reply other threads:[~2024-03-12 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 14:11 [kvm-unit-tests PATCH v1] arch-run: Wait for incoming socket being removed Nico Boehr
2024-03-05 18:12 ` Marc Hartmayer
2024-03-06 13:03 ` Nico Boehr
2024-03-12 5:39 ` Nicholas Piggin
2024-03-12 6:37 ` Nicholas Piggin
2024-03-12 6:45 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a2354b7-df7b-4371-a4fa-d1da29ae4dd3@redhat.com \
--to=thuth@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=nrb@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).