From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: cohuck@redhat.com, pasic@linux.vnet.ibm.com,
jjherne@linux.ibm.com, jgg@nvidia.com,
alex.williamson@redhat.com, kwankhede@nvidia.com,
frankja@linux.ibm.com, david@redhat.com, imbrenda@linux.ibm.com,
hca@linux.ibm.com
Subject: Re: [PATCH 3/3] s390/vfio-ap: r/w lock for PQAP interception handler function pointer
Date: Tue, 15 Jun 2021 14:55:42 -0400 [thread overview]
Message-ID: <29545a2f-cd64-9a89-4ecf-ea9b82bd64c4@linux.ibm.com> (raw)
In-Reply-To: <feff8d63-c2e0-73a3-83ae-a6a5e549194a@de.ibm.com>
On 6/15/21 4:55 AM, Christian Borntraeger wrote:
> On 10.06.21 00:46, Tony Krowiak wrote:
>> The function pointer to the interception handler for the PQAP
>> instruction
>> can get changed during the interception process. Let's add a
>> semaphore to struct kvm_s390_crypto to control read/write access to the
>> function pointer contained therein.
>>
>> The semaphore must be locked for write access by the vfio_ap device
>> driver
>> when notified that the KVM pointer has been set or cleared. It must be
>> locked for read access by the interception framework when the PQAP
>> instruction is intercepted.
>>
>> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
>
> Given that patch 2 is still under discussion. Can this patch go
> without patch 2?
Here's what I think I'm going to do. Patches 1 and 3 are related to the
patch
I posted to resolve the FIXME in the vfio_ap_mdev_remove() callback in a
patch
posted by Jason Gunthorpe (Message ID:
<6-v1-d88406ed308e+418-vfio3_jgg@nvidia.com>).
Patch 2 in this series was precipitated by a comment Jason made that was
not directly related to that fix, so I will put a two patch series
with patch 1 and 3, then test them and post them here before proceeding
to resolving the issues in patch 2 which I will post separately.
>> ---
>> arch/s390/include/asm/kvm_host.h | 6 +++---
>> arch/s390/kvm/kvm-s390.c | 1 +
>> arch/s390/kvm/priv.c | 6 +++---
>> drivers/s390/crypto/vfio_ap_ops.c | 14 ++++++++++----
>> drivers/s390/crypto/vfio_ap_private.h | 2 +-
>> 5 files changed, 18 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/s390/include/asm/kvm_host.h
>> b/arch/s390/include/asm/kvm_host.h
>> index 8925f3969478..58edaa3f9602 100644
>> --- a/arch/s390/include/asm/kvm_host.h
>> +++ b/arch/s390/include/asm/kvm_host.h
>> @@ -803,14 +803,14 @@ struct kvm_s390_cpu_model {
>> unsigned short ibc;
>> };
>> -struct kvm_s390_module_hook {
>> +struct kvm_s390_crypto_hook {
>> int (*hook)(struct kvm_vcpu *vcpu);
>> - struct module *owner;
>> };
>> struct kvm_s390_crypto {
>> struct kvm_s390_crypto_cb *crycb;
>> - struct kvm_s390_module_hook *pqap_hook;
>> + struct rw_semaphore pqap_hook_rwsem;
>> + struct kvm_s390_crypto_hook *pqap_hook;
>> __u32 crycbd;
>> __u8 aes_kw;
>> __u8 dea_kw;
>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>> index 1296fc10f80c..418d910df569 100644
>> --- a/arch/s390/kvm/kvm-s390.c
>> +++ b/arch/s390/kvm/kvm-s390.c
>> @@ -2606,6 +2606,7 @@ static void kvm_s390_crypto_init(struct kvm *kvm)
>> {
>> kvm->arch.crypto.crycb = &kvm->arch.sie_page2->crycb;
>> kvm_s390_set_crycb_format(kvm);
>> + init_rwsem(&kvm->arch.crypto.pqap_hook_rwsem);
>> if (!test_kvm_facility(kvm, 76))
>> return;
>> diff --git a/arch/s390/kvm/priv.c b/arch/s390/kvm/priv.c
>> index 9928f785c677..bbbd84ffe239 100644
>> --- a/arch/s390/kvm/priv.c
>> +++ b/arch/s390/kvm/priv.c
>> @@ -657,15 +657,15 @@ static int handle_pqap(struct kvm_vcpu *vcpu)
>> * Verify that the hook callback is registered, lock the owner
>> * and call the hook.
>> */
>> + down_read(&vcpu->kvm->arch.crypto.pqap_hook_rwsem);
>> if (vcpu->kvm->arch.crypto.pqap_hook) {
>> - if (!try_module_get(vcpu->kvm->arch.crypto.pqap_hook->owner))
>> - return -EOPNOTSUPP;
>> ret = vcpu->kvm->arch.crypto.pqap_hook->hook(vcpu);
>> - module_put(vcpu->kvm->arch.crypto.pqap_hook->owner);
>> if (!ret && vcpu->run->s.regs.gprs[1] & 0x00ff0000)
>> kvm_s390_set_psw_cc(vcpu, 3);
>> + up_read(&vcpu->kvm->arch.crypto.pqap_hook_rwsem);
>> return ret;
>> }
>> + up_read(&vcpu->kvm->arch.crypto.pqap_hook_rwsem);
>> /*
>> * A vfio_driver must register a hook.
>> * No hook means no driver to enable the SIE CRYCB and no queues.
>> diff --git a/drivers/s390/crypto/vfio_ap_ops.c
>> b/drivers/s390/crypto/vfio_ap_ops.c
>> index d65a5728153b..2998c1b53ab9 100644
>> --- a/drivers/s390/crypto/vfio_ap_ops.c
>> +++ b/drivers/s390/crypto/vfio_ap_ops.c
>> @@ -342,7 +342,6 @@ static int vfio_ap_mdev_create(struct mdev_device
>> *mdev)
>> init_rwsem(&matrix_mdev->rwsem);
>> mdev_set_drvdata(mdev, matrix_mdev);
>> matrix_mdev->pqap_hook.hook = handle_pqap;
>> - matrix_mdev->pqap_hook.owner = THIS_MODULE;
>> mutex_lock(&matrix_dev->lock);
>> list_add(&matrix_mdev->node, &matrix_dev->mdev_list);
>> @@ -1063,7 +1062,6 @@ static int vfio_ap_mdev_set_kvm(struct
>> ap_matrix_mdev *matrix_mdev,
>> down_write(&matrix_mdev->rwsem);
>> matrix_mdev->kvm = kvm;
>> kvm_get_kvm(kvm);
>> - kvm->arch.crypto.pqap_hook = &matrix_mdev->pqap_hook;
>> up_write(&matrix_mdev->rwsem);
>> /*
>> @@ -1071,6 +1069,10 @@ static int vfio_ap_mdev_set_kvm(struct
>> ap_matrix_mdev *matrix_mdev,
>> * masks for the KVM guest
>> */
>> if (kvm->arch.crypto.crycbd) {
>> + down_write(&matrix_mdev->kvm->arch.crypto.pqap_hook_rwsem);
>> + kvm->arch.crypto.pqap_hook = &matrix_mdev->pqap_hook;
>> + up_write(&matrix_mdev->kvm->arch.crypto.pqap_hook_rwsem);
>> +
>> down_read(&matrix_mdev->matrix.rwsem);
>> kvm_arch_crypto_set_masks(kvm,
>> matrix_mdev->matrix.apm,
>> @@ -1122,11 +1124,15 @@ static int vfio_ap_mdev_iommu_notifier(struct
>> notifier_block *nb,
>> static void vfio_ap_mdev_unset_kvm(struct ap_matrix_mdev *matrix_mdev)
>> {
>> if (matrix_mdev->kvm) {
>> - if (matrix_mdev->kvm->arch.crypto.crycbd)
>> + if (matrix_mdev->kvm->arch.crypto.crycbd) {
>> + down_write(&matrix_mdev->kvm->arch.crypto.pqap_hook_rwsem);
>> + matrix_mdev->kvm->arch.crypto.pqap_hook = NULL;
>> + up_write(&matrix_mdev->kvm->arch.crypto.pqap_hook_rwsem);
>> +
>> kvm_arch_crypto_clear_masks(matrix_mdev->kvm);
>> + }
>> down_write(&matrix_mdev->rwsem);
>> - matrix_mdev->kvm->arch.crypto.pqap_hook = NULL;
>> vfio_ap_mdev_reset_queues(matrix_mdev->mdev);
>> kvm_put_kvm(matrix_mdev->kvm);
>> matrix_mdev->kvm = NULL;
>> diff --git a/drivers/s390/crypto/vfio_ap_private.h
>> b/drivers/s390/crypto/vfio_ap_private.h
>> index a163ac04ff8a..3d6afd0faaaf 100644
>> --- a/drivers/s390/crypto/vfio_ap_private.h
>> +++ b/drivers/s390/crypto/vfio_ap_private.h
>> @@ -90,7 +90,7 @@ struct ap_matrix_mdev {
>> struct notifier_block iommu_notifier;
>> struct rw_semaphore rwsem;
>> struct kvm *kvm;
>> - struct kvm_s390_module_hook pqap_hook;
>> + struct kvm_s390_crypto_hook pqap_hook;
>> struct mdev_device *mdev;
>> };
>>
prev parent reply other threads:[~2021-06-15 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 22:46 [PATCH 0/3] s390/vfio-ap: refactor mdev remove callback and locks Tony Krowiak
2021-06-09 22:46 ` [PATCH 1/3] s390/vfio-ap: clean up mdev resources when remove callback invoked Tony Krowiak
2021-06-11 16:48 ` Jason Gunthorpe
2021-06-14 17:29 ` Tony Krowiak
2021-06-15 7:43 ` Christian Borntraeger
2021-06-09 22:46 ` [PATCH 2/3] s390/vfio-ap: introduce two new r/w locks to replace wait_queue_head_t Tony Krowiak
2021-06-11 17:05 ` Jason Gunthorpe
2021-06-11 17:11 ` David Hildenbrand
2021-06-11 17:41 ` Jason Gunthorpe
2021-06-09 22:46 ` [PATCH 3/3] s390/vfio-ap: r/w lock for PQAP interception handler function pointer Tony Krowiak
2021-06-11 17:06 ` Jason Gunthorpe
2021-06-15 8:55 ` Christian Borntraeger
2021-06-15 18:08 ` Tony Krowiak
2021-06-15 18:55 ` Tony Krowiak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29545a2f-cd64-9a89-4ecf-ea9b82bd64c4@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jgg@nvidia.com \
--cc=jjherne@linux.ibm.com \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).