From: Jean Delvare <jdelvare@suse.de>
To: linux-s390@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Subject: [PATCH RFC] s390/pci: Drop unneeded reference to CONFIG_DMI
Date: Tue, 23 Apr 2024 16:27:24 +0200 [thread overview]
Message-ID: <20240423162724.3966265a@endymion.delvare> (raw)
The S/390 architecture doesn't support SMBIOS, so CONFIG_DMI will
never be defined there. So we can simply omit these preprocessing
directives and speed up the build a bit.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
---
Niklas, you added these preprocessing directives as part of commit
81bbf03905aa ("s390/pci: expose a PCI device's UID as its index").
I do not understand the purpose. Am I missing something?
arch/s390/pci/pci_sysfs.c | 4 ----
1 file changed, 4 deletions(-)
--- linux-6.8.orig/arch/s390/pci/pci_sysfs.c
+++ linux-6.8/arch/s390/pci/pci_sysfs.c
@@ -156,7 +156,6 @@ static ssize_t uid_is_unique_show(struct
}
static DEVICE_ATTR_RO(uid_is_unique);
-#ifndef CONFIG_DMI
/* analogous to smbios index */
static ssize_t index_show(struct device *dev,
struct device_attribute *attr, char *buf)
@@ -186,7 +185,6 @@ static struct attribute_group zpci_ident
.attrs = zpci_ident_attrs,
.is_visible = zpci_index_is_visible,
};
-#endif
static struct bin_attribute *zpci_bin_attrs[] = {
&bin_attr_util_string,
@@ -229,8 +227,6 @@ static struct attribute_group pfip_attr_
const struct attribute_group *zpci_attr_groups[] = {
&zpci_attr_group,
&pfip_attr_group,
-#ifndef CONFIG_DMI
&zpci_ident_attr_group,
-#endif
NULL,
};
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2024-04-23 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 14:27 Jean Delvare [this message]
2024-04-24 11:34 ` [PATCH RFC] s390/pci: Drop unneeded reference to CONFIG_DMI Niklas Schnelle
2024-04-24 12:05 ` Alexander Gordeev
2024-04-24 12:08 ` Jean Delvare
2024-04-24 12:27 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240423162724.3966265a@endymion.delvare \
--to=jdelvare@suse.de \
--cc=gerald.schaefer@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).