From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-s390@vger.kernel.org
Cc: jack@suse.cz, hch@lst.de, brauner@kernel.org, axboe@kernel.dk,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com,
Yu Kuai <yukuai1@huaweicloud.com>
Subject: Re: [PATCH vfs.all 15/26] s390/dasd: use bdev api in dasd_format()
Date: Tue, 16 Apr 2024 02:35:55 +0100 [thread overview]
Message-ID: <20240416013555.GZ2118490@ZenIV> (raw)
In-Reply-To: <20240406090930.2252838-16-yukuai1@huaweicloud.com>
On Sat, Apr 06, 2024 at 05:09:19PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Avoid to access bd_inode directly, prepare to remove bd_inode from
> block_devcie.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Jan Kara <jack@suse.cz>
> ---
> drivers/s390/block/dasd_ioctl.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_ioctl.c b/drivers/s390/block/dasd_ioctl.c
> index 7e0ed7032f76..c1201590f343 100644
> --- a/drivers/s390/block/dasd_ioctl.c
> +++ b/drivers/s390/block/dasd_ioctl.c
> @@ -215,8 +215,9 @@ dasd_format(struct dasd_block *block, struct format_data_t *fdata)
> * enabling the device later.
> */
> if (fdata->start_unit == 0) {
> - block->gdp->part0->bd_inode->i_blkbits =
> - blksize_bits(fdata->blksize);
> + rc = set_blocksize(block->gdp->part0, fdata->blksize);
Could somebody (preferably s390 folks) explain what is going on in
dasd_format()? The change in this commit is *NOT* an equivalent
transformation - mainline does not evict the page cache of device.
Is that
* intentional behaviour in mainline version, possibly broken
by this patch
* a bug in mainline accidentally fixed by this patch
* something else?
And shouldn't there be an exclusion between that and having a filesystem
on a partition of that disk currently mounted?
next parent reply other threads:[~2024-04-16 1:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240406090930.2252838-1-yukuai1@huaweicloud.com>
[not found] ` <20240406090930.2252838-16-yukuai1@huaweicloud.com>
2024-04-16 1:35 ` Al Viro [this message]
2024-04-16 8:47 ` [PATCH vfs.all 15/26] s390/dasd: use bdev api in dasd_format() Alexander Gordeev
2024-04-17 12:47 ` Stefan Haberland
2024-04-28 18:58 ` Al Viro
2024-04-28 23:23 ` Al Viro
2024-04-29 14:41 ` Stefan Haberland
2024-04-30 0:30 ` Al Viro
2024-04-30 11:35 ` Stefan Haberland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240416013555.GZ2118490@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).