Linux-S390 Archive mirror
 help / color / mirror / Atom feed
From: Heiko Carstens <hca@linux.ibm.com>
To: "Jason J. Herne" <jjherne@linux.ibm.com>
Cc: Anthony Krowiak <akrowiak@linux.ibm.com>,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	pasic@linux.ibm.com, borntraeger@de.ibm.com,
	agordeev@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH v3 0/5] s390/vfio-ap: ap_config sysfs attribute for mdevctl automation
Date: Thu, 21 Mar 2024 15:41:41 +0100	[thread overview]
Message-ID: <20240321144141.6215-A-hca@linux.ibm.com> (raw)
In-Reply-To: <7307842e-769e-92df-800a-0bf78fe0b70b@linux.ibm.com>

Hi Jason,

> > In function ‘bitmap_copy’,
> >      inlined from ‘ap_matrix_copy’ at drivers/s390/crypto/vfio_ap_ops.c:1674:2,
> >      inlined from ‘ap_config_store’ at drivers/s390/crypto/vfio_ap_ops.c:1696:2:
> > ./include/linux/bitmap.h:253:17: warning: ‘memcpy’ reading 32 bytes from a region of size 0 [-Wstringop-overread]
> >    253 |                 memcpy(dst, src, len);
> >        |                 ^~~~~~~~~~~~~~~~~~~~~
> > In function ‘ap_config_store’:
> > cc1: note: source object is likely at address zero
> 
> I believe that this is a bogus compiler warning. I cannot reproduce it,
> fwiw.
> 
> gcc:     gcc (GCC) 13.2.1 20231205 (Red Hat 13.2.1-6)
> binutls  binutils-2.40-14.fc39
...
> A quick web search seems to indicate gcc throws quite a few
> Wstringop-overread warnings for valid code. I suspect this is
> another example of that.

This might be the case, however the code has to compile without
warnings also with plain gcc 13.2.0 (built from source).

      reply	other threads:[~2024-03-21 14:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-13 20:58 [PATCH v3 0/5] s390/vfio-ap: ap_config sysfs attribute for mdevctl automation Jason J. Herne
2024-03-13 20:58 ` [PATCH v3 1/5] s390/ap: Externalize AP bus specific bitmap reading function Jason J. Herne
2024-03-13 20:58 ` [PATCH v3 2/5] s390/vfio-ap: Add sysfs attr, ap_config, to export mdev state Jason J. Herne
2024-03-13 20:58 ` [PATCH v3 3/5] s390/vfio-ap: Ignore duplicate link requests in vfio_ap_mdev_link_queue Jason J. Herne
2024-03-13 20:58 ` [PATCH v3 4/5] s390/vfio-ap: Add write support to sysfs attr ap_config Jason J. Herne
2024-03-15 14:45   ` Anthony Krowiak
2024-03-13 20:58 ` [PATCH v3 5/5] docs: Update s390 vfio-ap doc for ap_config sysfs attribute Jason J. Herne
2024-03-15 14:46   ` Anthony Krowiak
2024-03-15 14:48 ` [PATCH v3 0/5] s390/vfio-ap: ap_config sysfs attribute for mdevctl automation Anthony Krowiak
2024-03-19 11:12   ` Heiko Carstens
2024-03-21 14:14     ` Jason J. Herne
2024-03-21 14:41       ` Heiko Carstens [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240321144141.6215-A-hca@linux.ibm.com \
    --to=hca@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akrowiak@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=jjherne@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).