From: Guenter Roeck <linux@roeck-us.net>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v5 2/2] rtc: max31335: add driver support
Date: Fri, 3 Nov 2023 12:48:27 -0700 [thread overview]
Message-ID: <f2a58018-d907-4401-a2d9-fe53bebc1459@roeck-us.net> (raw)
In-Reply-To: <20231103140051.43174-2-antoniu.miclaus@analog.com>
On Fri, Nov 03, 2023 at 04:00:26PM +0200, Antoniu Miclaus wrote:
> RTC driver for MAX31335 ±2ppm Automotive Real-Time Clock with
> Integrated MEMS Resonator.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> MAINTAINERS | 8 +
> drivers/rtc/Kconfig | 20 ++
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-max31335.c | 700 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 729 insertions(+)
> create mode 100644 drivers/rtc/rtc-max31335.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dd5de540ec0b..bc484cb997ab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -12823,6 +12823,14 @@ F: Documentation/devicetree/bindings/hwmon/adi,max31827.yaml
> F: Documentation/hwmon/max31827.rst
> F: drivers/hwmon/max31827.c
>
> +MAX31335 RTC DRIVER
> +M: Antoniu Miclaus <antoniu.miclaus@analog.com>
> +L: linux-rtc@vger.kernel.org
> +S: Supported
> +W: https://ez.analog.com/linux-software-drivers
> +F: Documentation/devicetree/bindings/rtc/adi,max31335.yaml
> +F: drivers/rtc/rtc-max31335.c
> +
> MAX6650 HARDWARE MONITOR AND FAN CONTROLLER DRIVER
> L: linux-hwmon@vger.kernel.org
> S: Orphan
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index d7502433c78a..360da13fe61b 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -373,6 +373,26 @@ config RTC_DRV_MAX8997
> This driver can also be built as a module. If so, the module
> will be called rtc-max8997.
>
> +config RTC_DRV_MAX31335
> + tristate "Analog Devices MAX31335"
> + depends on I2C
> + select REGMAP_I2C
> + help
> + If you say yes here you get support for the Analog Devices
> + MAX31335.
> +
> + This driver can also be built as a module. If so, the module
> + will be called rtc-max31335.
> +
> +config RTC_DRV_MAX31335_HWMON
> + bool "HWMON support for Analog Devices MAX31335"
> + depends on RTC_DRV_MAX31335 && HWMON
> + depends on !(RTC_DRV_MAX31335=y && HWMON=m)
> + default y
> + help
> + Say Y here if you want to expose temperature sensor data on
> + rtc-max31335.
CONFIG_RTC_DRV_MAX31335_HWMON is not used in the driver. What is the point
of having it ?
Guenter
next prev parent reply other threads:[~2023-11-03 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 14:00 [PATCH v5 1/2] dt-bindings: rtc: max31335: add max31335 bindings Antoniu Miclaus
2023-11-03 14:00 ` [PATCH v5 2/2] rtc: max31335: add driver support Antoniu Miclaus
2023-11-03 19:48 ` Guenter Roeck [this message]
2023-11-03 15:23 ` [PATCH v5 1/2] dt-bindings: rtc: max31335: add max31335 bindings Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a58018-d907-4401-a2d9-fe53bebc1459@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).