From: Biju Das <biju.das.jz@bp.renesas.com>
To: Thomas Gleixner <tglx@linutronix.de>,
John Stultz <jstultz@google.com>, Stephen Boyd <sboyd@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Stultz <jstultz@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.au@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Trent Piepho <tpiepho@gmail.com>
Subject: RE: [Query]: Resource cleanup for Alarmtimer
Date: Wed, 20 Sep 2023 11:46:56 +0000 [thread overview]
Message-ID: <OS0PR01MB5922E907FCC5B7638B9CA29A86F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OS0PR01MB5922DD412F43E1C836E32AF486F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
HI all,
I will send a patch to fix this issue soon. We will discuss
this topic there.
Cheers,
Biju
> Subject: [Query]: Resource cleanup for Alarmtimer
>
> Hi All,
>
> Currently unbind/bind is not working as expected on rtc-isl1208 driver. The
> reason is put_device() is not calling rtc_device_release() as some of the
> kobjects are not freed during unbind.
>
> The commit c79108bd19a8 "alarmtimer: Make alarmtimer platform device
> child of RTC device" adds kobjects for alarmtimer device/sysfs, when we
> call device_init_wakeup() followed by devm_rtc_register_device()from the
> end point driver during probe().
> But these kobjects are never freed when we do unbind on the endpoint
> driver.
>
> The alarm timer device has alarmtimer_rtc_add_device() but it does not have
> remove_device() callbacks to free kbjects.
>
> Q1) Has anyone tested unbind/rebind on RTC subsystem with
> device_init_wakeup() followed by devm_rtc_register_device() in the probe?
>
> Cheers,
> Biju
>
prev parent reply other threads:[~2023-09-20 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 8:12 [Query]: Resource cleanup for Alarmtimer Biju Das
2023-09-20 11:46 ` Biju Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB5922E907FCC5B7638B9CA29A86F9A@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.au@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tpiepho@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).