From: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc: alexandre.belloni@bootlin.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
chao.wei@sophgo.com, unicorn_wang@outlook.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, dlan@gentoo.org
Subject: Re: [PATCH v7 3/3] riscv: dts: sophgo: add rtc dt node for CV1800
Date: Tue, 23 Jan 2024 09:24:24 +0800 [thread overview]
Message-ID: <CAJRtX8SiVazctKcmbrM3qhooQ9J_yuSAuUAh-nSW+sk8NWKv2g@mail.gmail.com> (raw)
In-Reply-To: <CAJM55Z_DFox9c_eDeHtx9H+9e4A6pjkCkt7po94j_mu-tQWywg@mail.gmail.com>
On Mon, Jan 22, 2024 at 9:25 PM Emil Renner Berthing
<emil.renner.berthing@canonical.com> wrote:
>
> Jingbao Qiu wrote:
> > Add the rtc device tree node to cv1800 SoC.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> > ---
> > arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > index df40e87ee063..0cd7eb9a3048 100644
> > --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> > @@ -119,5 +119,12 @@ clint: timer@74000000 {
> > reg = <0x74000000 0x10000>;
> > interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>;
> > };
> > +
> > + rtc: rtc@5025000 {
> > + compatible = "sophgo,cv1800-rtc";
> > + reg = <0x5025000 0x2000>;
> > + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&osc>;
> > + };
>
> Before this patch it looks like the nodes are sorted by their address,
> but this would break it.
Thanks, I will fix it.
Best regards,
Jingbao Qiu
next prev parent reply other threads:[~2024-01-23 1:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:06 [PATCH v7 2/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC Jingbao Qiu
2024-01-22 8:06 ` [PATCH v7 3/3] riscv: dts: sophgo: add rtc dt node for CV1800 Jingbao Qiu
2024-01-22 13:25 ` Emil Renner Berthing
2024-01-23 1:24 ` Jingbao Qiu [this message]
2024-01-22 8:17 ` [PATCH v7 2/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC Alexandre Belloni
2024-01-22 8:34 ` Jingbao Qiu
2024-01-22 8:37 ` Krzysztof Kozlowski
2024-01-22 8:42 ` Jingbao Qiu
2024-01-22 9:15 ` Alexandre Belloni
2024-01-22 9:23 ` Jingbao Qiu
2024-01-22 8:29 ` Krzysztof Kozlowski
2024-01-22 8:38 ` Jingbao Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJRtX8SiVazctKcmbrM3qhooQ9J_yuSAuUAh-nSW+sk8NWKv2g@mail.gmail.com \
--to=qiujingbao.dlmu@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=emil.renner.berthing@canonical.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).