From: kernel test robot <lkp@intel.com>
To: Richard Genoud <richard.genoud@bootlin.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: oe-kbuild-all@lists.linux.dev,
Esteban Blanc <eblanc@baylibre.com>,
linux-rtc@vger.kernel.org, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org,
Richard Genoud <richard.genoud@bootlin.com>
Subject: Re: [PATCH] rtc: tps6594: Add power management support
Date: Tue, 14 May 2024 15:09:30 +0800 [thread overview]
Message-ID: <202405141408.o5jSp8nU-lkp@intel.com> (raw)
In-Reply-To: <20240513162942.68484-1-richard.genoud@bootlin.com>
Hi Richard,
kernel test robot noticed the following build warnings:
[auto build test WARNING on abelloni/rtc-next]
[also build test WARNING on lee-mfd/for-mfd-next lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.9 next-20240513]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Richard-Genoud/rtc-tps6594-Add-power-management-support/20240514-003053
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
patch link: https://lore.kernel.org/r/20240513162942.68484-1-richard.genoud%40bootlin.com
patch subject: [PATCH] rtc: tps6594: Add power management support
config: sparc-randconfig-r081-20240514 (https://download.01.org/0day-ci/archive/20240514/202405141408.o5jSp8nU-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240514/202405141408.o5jSp8nU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405141408.o5jSp8nU-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/rtc/rtc-tps6594.c:471:12: warning: 'tps6594_rtc_suspend' defined but not used [-Wunused-function]
471 | static int tps6594_rtc_suspend(struct device *dev)
| ^~~~~~~~~~~~~~~~~~~
>> drivers/rtc/rtc-tps6594.c:439:12: warning: 'tps6594_rtc_resume' defined but not used [-Wunused-function]
439 | static int tps6594_rtc_resume(struct device *dev)
| ^~~~~~~~~~~~~~~~~~
vim +/tps6594_rtc_suspend +471 drivers/rtc/rtc-tps6594.c
438
> 439 static int tps6594_rtc_resume(struct device *dev)
440 {
441 struct tps6594 *tps = dev_get_drvdata(dev->parent);
442 struct rtc_device *rtc_dev = dev_get_drvdata(dev);
443 int ret;
444
445 ret = regmap_test_bits(tps->regmap, TPS6594_REG_INT_STARTUP,
446 TPS6594_BIT_RTC_INT);
447 if (ret < 0) {
448 dev_err(dev, "failed to read REG_INT_STARTUP: %d\n", ret);
449 goto out;
450 }
451
452 if (ret > 0) {
453 /*
454 * If the alarm bit is set, it means that the IRQ has been
455 * fired. But, the kernel may not have woke up yet when it
456 * happened. So, we have to clear it.
457 */
458 ret = regmap_write(tps->regmap, TPS6594_REG_RTC_STATUS,
459 TPS6594_BIT_ALARM);
460 if (ret < 0)
461 dev_err(dev, "error clearing alarm bit: %d", ret);
462
463 rtc_update_irq(rtc_dev, 1, RTC_IRQF | RTC_AF);
464 }
465 out:
466 disable_irq_wake(tps->irq_rtc);
467
468 return 0;
469 }
470
> 471 static int tps6594_rtc_suspend(struct device *dev)
472 {
473 struct tps6594 *tps = dev_get_drvdata(dev->parent);
474
475 enable_irq_wake(tps->irq_rtc);
476
477 return 0;
478 }
479
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-05-14 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 16:29 [PATCH] rtc: tps6594: Add power management support Richard Genoud
2024-05-14 7:09 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405141408.o5jSp8nU-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=eblanc@baylibre.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=richard.genoud@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).