From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: antoniu.miclaus@analog.com, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jdelvare@suse.com, linux@roeck-us.net
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v7 0/2] drivers: rtc: add max313xx series rtc driver
Date: Tue, 20 Feb 2024 11:18:22 +1300 [thread overview]
Message-ID: <20240219221827.3821415-1-chris.packham@alliedtelesis.co.nz> (raw)
Datasheets:
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31328.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31329.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31331.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31334.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31341B-MAX31341C.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31342.pdf
https://www.analog.com/media/en/technical-documentation/data-sheets/MAX31343.pdf
Note that I've only got access to a MAX31334 to test with. I'm relying on the
fact that Ibrahim would have been testing on the other variants through earlier
iterations of this series. I've also made a best effort attempt to integrate
the MAX31335 support with the more generic code but as the datasheet is not
public I can't be sure it's been done correctly and the MAX31335 has definitely
not been tested with this updated code (Antoniu if you could test it on your
hardware that would really help).
changelog:
since v6:
- Roll changes into max31335 driver that was landed while this was
in-flight.
- Adjusted code order and variable names to reduce the delta with
the max31335
since v5:
- change of maintainer
- use adi,ti-diode property
- deal with oscillator fail and releasing SWRST
since v4:
- dt-binding: add enum value "2" to aux-voltage-chargable
- dt-binding: remove adi,trickle-diode-enable
- dt-binding: change description of trickle-resistor-ohms
- dt-binding: reorder as in example schema
- parse "wakeup-source" when irq not requested
- remove limitation on max31328 irq and clockout
- remove error and warning messages during trickle charger setup
since v3:
- dt-binding: remove interrupt names.
- dt-binding: add description for "interrupts" property
- dt-binding: replace deprecated property "trickle-diode-disable"
by "aux-voltage-chargeable"
- dt-binding: add new property "adi,trickle-diode-enable"
- dt-binding: remove "wakeup-source"
- use clear_bit instead of __clear_bit
- use devm_of_clk_add_hw_provider instead of of_clk_add_provider
- use chip_desc pointer as driver data instead of enum.
since v2:
- add "break" to fix warning: unannotated fall-through
Reported-by: kernel test robot <lkp@intel.com>
since v1:
- dt-binding: update title and description
- dt-binding: remove last example
- drop watchdog support
- support reading 12Hr format instead of forcing 24hr at probe time
- use "tm_year % 100" instead of range check
- refactor max313xx_init for readability
Ibrahim Tilki (2):
drivers: rtc: add max313xx series rtc driver
dt-bindings: rtc: add max313xx RTCs
.../devicetree/bindings/rtc/adi,max31335.yaml | 70 -
.../devicetree/bindings/rtc/adi,max313xx.yaml | 167 +++
drivers/rtc/Kconfig | 2 +-
drivers/rtc/rtc-max31335.c | 1154 +++++++++++------
4 files changed, 958 insertions(+), 435 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/rtc/adi,max31335.yaml
create mode 100644 Documentation/devicetree/bindings/rtc/adi,max313xx.yaml
--
2.43.2
next reply other threads:[~2024-02-19 22:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 22:18 Chris Packham [this message]
2024-02-19 22:18 ` [PATCH v7 1/2] drivers: rtc: add max313xx series rtc driver Chris Packham
2024-02-20 19:42 ` Guenter Roeck
2024-02-20 20:07 ` Chris Packham
2024-02-20 22:56 ` kernel test robot
2024-02-21 18:04 ` kernel test robot
2024-02-19 22:18 ` [PATCH v7 2/2] dt-bindings: rtc: add max313xx RTCs Chris Packham
2024-02-20 19:21 ` Conor Dooley
2024-02-20 20:11 ` Chris Packham
2024-02-21 20:02 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240219221827.3821415-1-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=alexandre.belloni@bootlin.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).