From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, tobrohl@gmail.com, aalsing@gmail.com,
Dhaval.Giani@amd.com, xmb8dsv4@gmail.com, x86@kernel.org,
dhaval.giani@gmail.com
Subject: Re: [PATCH v2 0/4] Extend time to wait for UIP for some callers
Date: Thu, 23 Nov 2023 09:31:40 +0100 [thread overview]
Message-ID: <20231123083140e5e75ba2@mail.local> (raw)
In-Reply-To: <20231120141555.458-1-mario.limonciello@amd.com>
On 20/11/2023 08:15:51-0600, Mario Limonciello wrote:
> A number of users have reported their system will have a failure reading
> the RTC around s2idle entry or exit.
>
> This failure manifests as UIP clear taking longer than 10ms.
>
> By a debugging patch provided by Mateusz Jończyk it is shown that this
> has taken upwards of 300ms in some cases.
>
> This series adjusts the UIP timeout to be configurable by the caller and
> changes some callers which aren't called in an interrupt context to allow
> longer timeouts.
>
> Mario Limonciello (4):
> rtc: mc146818-lib: Adjust failure return code for mc146818_get_time()
> rtc: Adjust failure return code for cmos_set_alarm()
> rtc: Add support for configuring the UIP timeout for RTC reads
> rtc: Extend timeout for waiting for UIP to clear to 1s
>
> arch/alpha/kernel/rtc.c | 2 +-
> arch/x86/kernel/hpet.c | 2 +-
> arch/x86/kernel/rtc.c | 2 +-
Please also copy the x86 maintainers so they know I'm going to carry
patches that may affect them (which I doubt will cause any issues)
> drivers/base/power/trace.c | 2 +-
> drivers/rtc/rtc-cmos.c | 10 ++++-----
> drivers/rtc/rtc-mc146818-lib.c | 37 +++++++++++++++++++++++++---------
> include/linux/mc146818rtc.h | 3 ++-
> 7 files changed, 39 insertions(+), 19 deletions(-)
>
>
> base-commit: 98b1cc82c4affc16f5598d4fa14b1858671b2263
> --
> 2.34.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-11-23 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 14:15 [PATCH v2 0/4] Extend time to wait for UIP for some callers Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 1/4] rtc: mc146818-lib: Adjust failure return code for mc146818_get_time() Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 2/4] rtc: Adjust failure return code for cmos_set_alarm() Mario Limonciello
2023-11-20 14:15 ` [PATCH v2 3/4] rtc: Add support for configuring the UIP timeout for RTC reads Mario Limonciello
2023-11-22 17:06 ` Mateusz Jończyk
2023-11-20 14:15 ` [PATCH v2 4/4] rtc: Extend timeout for waiting for UIP to clear to 1s Mario Limonciello
2023-11-22 17:16 ` Mateusz Jończyk
2023-11-22 16:58 ` [PATCH v2 0/4] Extend time to wait for UIP for some callers Mateusz Jończyk
2023-11-23 8:31 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123083140e5e75ba2@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Dhaval.Giani@amd.com \
--cc=a.zummo@towertech.it \
--cc=aalsing@gmail.com \
--cc=dhaval.giani@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mat.jonczyk@o2.pl \
--cc=tobrohl@gmail.com \
--cc=x86@kernel.org \
--cc=xmb8dsv4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).