From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Miclaus, Antoniu" <Antoniu.Miclaus@analog.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] rtc: max31335: add driver support
Date: Wed, 1 Nov 2023 19:54:09 +0100 [thread overview]
Message-ID: <202311011854099f524c30@mail.local> (raw)
In-Reply-To: <CY4PR03MB3399DEF73E052036AC7EDBA99BA0A@CY4PR03MB3399.namprd03.prod.outlook.com>
On 31/10/2023 16:28:07+0000, Miclaus, Antoniu wrote:
> > According to the register map above, the chip does support
> > low and high temperature limits as well as over- and undertemperature
> > alarms and interrupts. I would suggest to add support for all of those.
> > You might also consider adding support for temperature alarm interrupts
> > and report temperature alarm events by calling hwmon_notify_event()
> > if a thermal event occurs.
>
> I've sent in the first version of this patch series a cover letter:
>
> "Although the datasheet is not public yet, the driver can be made public (on
> other linux custom trees it is already).
>
> The driver was tested with actual hardware and works.
>
Did you run rtctest? Please provide the output.
> Even though the datasheet is not available, if there are any queries about
> the functionality of the part, these can be provided/inserted as code comments
> inside the driver."
>
> The reason why I am rushing this a bit is because the customer that uses the
> driver wants the driver released and mainline kernel compliant.
>
> This is an initial version of the driver covering the main use cases (which were
> requested, therefore actually used).
>
> Additional features can be added afterwards, if requested.
>
> >
> > > +
> > > + hwmon = devm_hwmon_device_register_with_info(&client->dev,
> > client->name,
> > > + max31335,
> > > + &max31335_chip_info,
> > > + NULL);
> >
> > There is no "depends on HWMON" in the Kconfig entry, meaning this will fail
> > to compile if HWMON=n or if HWMON=m and RTC_DRV_MAX31335=y.
> >
>
> Will do in v4.
>
> > Guenter
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-11-01 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 15:30 [PATCH v3 1/2] dt-bindings: rtc: max31335: add max31335 bindings Antoniu Miclaus
2023-10-31 15:30 ` [PATCH v3 2/2] rtc: max31335: add driver support Antoniu Miclaus
2023-10-31 16:01 ` Guenter Roeck
2023-10-31 16:28 ` Miclaus, Antoniu
2023-11-01 18:54 ` Alexandre Belloni [this message]
2023-10-31 17:08 ` [PATCH v3 1/2] dt-bindings: rtc: max31335: add max31335 bindings Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311011854099f524c30@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Antoniu.Miclaus@analog.com \
--cc=a.zummo@towertech.it \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).