From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
Howard Harte <hharte@magicandroidapps.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] rtc: rtc7301: Rewrite bindings in schema
Date: Tue, 10 Oct 2023 09:23:48 -0500 [thread overview]
Message-ID: <20231010142348.GA833404-robh@kernel.org> (raw)
In-Reply-To: <20231007-rtc-7301-regwidth-v2-1-c913aa95f666@linaro.org>
On Sat, Oct 07, 2023 at 02:30:49PM +0200, Linus Walleij wrote:
> This rewrites the Epson RTC7301 bindings to use YAML schema,
> and adds a property for "reg-io-width" as used in several
> other bindings to account for different register strides.
>
> The USRobotics USR8200 uses the byte IO width.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../devicetree/bindings/rtc/epson,rtc7301.txt | 16 -------
> .../devicetree/bindings/rtc/epson,rtc7301.yaml | 50 ++++++++++++++++++++++
> 2 files changed, 50 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt b/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt
> deleted file mode 100644
> index 5f9df3f1467c..000000000000
> --- a/Documentation/devicetree/bindings/rtc/epson,rtc7301.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -EPSON TOYOCOM RTC-7301SF/DG
> -
> -Required properties:
> -
> -- compatible: Should be "epson,rtc7301sf" or "epson,rtc7301dg"
> -- reg: Specifies base physical address and size of the registers.
> -- interrupts: A single interrupt specifier.
> -
> -Example:
> -
> -rtc: rtc@44a00000 {
> - compatible = "epson,rtc7301dg";
> - reg = <0x44a00000 0x10000>;
> - interrupt-parent = <&axi_intc_0>;
> - interrupts = <3 2>;
> -};
> diff --git a/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml
> new file mode 100644
> index 000000000000..0937b094821d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/epson,rtc7301.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/epson,rtc7301.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Epson Toyocom RTC-7301SF/DG
> +
> +description:
> + The only difference between the two variants is the packaging.
> + The DG variant is a DIL package, and the SF variant is a flat
> + package.
> +
> +maintainers:
> + - Akinobu Mita <akinobu.mita@gmail.com>
> +
> +properties:
> + compatible:
> + enum:
> + - epson,rtc7301dg
> + - epson,rtc7301sf
> +
> + reg:
> + maxItems: 1
> +
> + reg-io-width:
> + description:
> + The size (in bytes) of the IO accesses that should be performed
> + on the device. If not specified, the default is 4.
No prose for what can be a constraint:
default: 4
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> + enum: [1, 4]
next prev parent reply other threads:[~2023-10-10 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-07 12:30 [PATCH v2 0/2] Support byte access in the RTC7301 driver Linus Walleij
2023-10-07 12:30 ` [PATCH v2 1/2] rtc: rtc7301: Rewrite bindings in schema Linus Walleij
2023-10-10 14:23 ` Rob Herring [this message]
2023-10-07 12:30 ` [PATCH v2 2/2] rtc: rtc7301: Support byte-addressed IO Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010142348.GA833404-robh@kernel.org \
--to=robh@kernel.org \
--cc=a.zummo@towertech.it \
--cc=akinobu.mita@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hharte@magicandroidapps.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).