From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Hector Martin" <marcan@marcan.st>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Komal Bajaj" <quic_kbajaj@quicinc.com>,
linux-rtc@vger.kernel.org,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
linux-mtd@lists.infradead.org,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Vincent Shih" <vincent.sunplus@gmail.com>,
asahi@lists.linux.dev, "Rob Herring" <robh+dt@kernel.org>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Andy Gross" <agross@kernel.org>,
linux-rockchip@lists.infradead.org,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Richard Weinberger" <richard@nod.at>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Sven Peter" <sven@svenpeter.dev>,
linux-arm-kernel@lists.infradead.org,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Kumar Thella" <sthella@codeaurora.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
devicetree@vger.kernel.org,
"Masami Hiramatsu" <mhiramat@kernel.org>,
linux-arm-msm@vger.kernel.org,
"Keiji Hayashibara" <hayashibara.keiji@socionext.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
linux-mediatek@lists.infradead.org,
"Lala Lin" <lala.lin@mediatek.com>
Subject: Re: [PATCH] dt-bindings: nvmem: move deprecated cells binding to its own file
Date: Tue, 03 Oct 2023 01:34:09 -0500 [thread overview]
Message-ID: <169631484962.3548819.1223779643388796546.robh@kernel.org> (raw)
In-Reply-To: <20231003050355.1631-1-zajec5@gmail.com>
On Tue, 03 Oct 2023 07:03:55 +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Support for old NVMEM fixed cells was deprecated in favour of
> "fixed-layout". It's still part of the nvmem.yaml though and may be
> unknowingly used by new bindings added without much of analyze.
>
> To make it more difficult to accidentally support old syntax move its
> binding to separated file with "deprecated" in its name.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../devicetree/bindings/mtd/mtd.yaml | 7 ++++-
> .../bindings/mtd/partitions/nvmem-cells.yaml | 1 +
> .../nvmem/amlogic,meson-gxbb-efuse.yaml | 1 +
> .../bindings/nvmem/amlogic,meson6-efuse.yaml | 1 +
> .../bindings/nvmem/apple,efuses.yaml | 1 +
> .../devicetree/bindings/nvmem/imx-ocotp.yaml | 1 +
> .../bindings/nvmem/mediatek,efuse.yaml | 1 +
> .../nvmem/microchip,sama7g5-otpc.yaml | 1 +
> .../devicetree/bindings/nvmem/mxs-ocotp.yaml | 1 +
> .../nvmem/nvmem-deprecated-cells.yaml | 28 +++++++++++++++++++
> .../devicetree/bindings/nvmem/nvmem.yaml | 9 ------
> .../bindings/nvmem/qcom,qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,sec-qfprom.yaml | 1 +
> .../bindings/nvmem/qcom,spmi-sdam.yaml | 1 +
> .../bindings/nvmem/rockchip,otp.yaml | 1 +
> .../bindings/nvmem/rockchip-efuse.yaml | 1 +
> .../nvmem/socionext,uniphier-efuse.yaml | 1 +
> .../bindings/nvmem/sunplus,sp7021-ocotp.yaml | 1 +
> .../bindings/rtc/amlogic,meson6-rtc.yaml | 1 +
> 19 files changed, 50 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/nvmem/nvmem-deprecated-cells.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.yaml:
Error in referenced schema matching $id: http://devicetree.org/schemas/rtc/nvmem-deprecated-cells.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: False schema does not allow {'compatible': ['amlogic,meson6-rtc'], 'reg': [[1856, 20]], 'interrupts': [[0, 72, 1]], 'clocks': [[4294967295]], 'vdd-supply': [[4294967295]], 'resets': [[4294967295]], '#address-cells': [[1]], '#size-cells': [[1]], 'mac@0': {'reg': [[0, 6]]}, '$nodename': ['rtc@740']}
from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/rtc/amlogic,meson6-rtc.example.dtb: rtc@740: Unevaluated properties are not allowed ('mac@0' was unexpected)
from schema $id: http://devicetree.org/schemas/rtc/amlogic,meson6-rtc.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231003050355.1631-1-zajec5@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
prev parent reply other threads:[~2023-10-03 6:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 5:03 [PATCH] dt-bindings: nvmem: move deprecated cells binding to its own file Rafał Miłecki
2023-10-03 6:34 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169631484962.3548819.1223779643388796546.robh@kernel.org \
--to=robh@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alyssa@rosenzweig.io \
--cc=andersson@kernel.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=asahi@lists.linux.dev \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hayashibara.keiji@socionext.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lala.lin@mediatek.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=martin.blumenstingl@googlemail.com \
--cc=matthias.bgg@gmail.com \
--cc=mhiramat@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_kbajaj@quicinc.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=sthella@codeaurora.org \
--cc=sven@svenpeter.dev \
--cc=vigneshr@ti.com \
--cc=vincent.sunplus@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).