From: John Kacur <jkacur@redhat.com>
To: Crystal Wood <crwood@redhat.com>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [PATCH 1/4] rt-tests: Fix warnings
Date: Mon, 18 Dec 2023 16:11:20 -0500 (EST) [thread overview]
Message-ID: <a1744cf8-9fba-9989-71d3-f726f8fadde8@redhat.com> (raw)
In-Reply-To: <767629d0eec7fa2203d4e6502da9a0d52ae993a2.camel@redhat.com>
On Mon, 18 Dec 2023, Crystal Wood wrote:
> On Thu, 2023-12-14 at 10:48 -0500, John Kacur wrote:
> >
> > I tested this with rteval, and it works fine
> > checkpatch in the linux kernel flags a few minor things.
> > Would you mind fixing those up before I apply the patch?
> >
> > WARNING: Improper SPDX comment style for 'src/include/histogram.h', please
> > use '/*' instead
> > #227: FILE: src/include/histogram.h:1:
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> >
> > (Yes, I know there are other files in rt-tests that also aren't using
> > the recommended commenting style, you probably copied from there.)
>
> This confused me for quite a bit, until I saw in
> Documentation/process/license-rules.rst that *sources* get // but *headers*
> get /*. The rationale seems to be based on the behavior of old toolchains
> when processing assembly code, linker scripts, etc. Doesn't seem terribly
> relevant to non-kernel projects...
>
> I can still "fix" it if you want.
>
>
> >
> > ERROR: trailing whitespace
> > #338: FILE: src/lib/histogram.c:64:
> > +^I^I$
>
> One of these days I need to teach the joe editor not to do this...
>
> -Crystal
>
>
>
No, your explanation works for me! Just fix the warnings about
the brace styles and I'll apply it.
John
next prev parent reply other threads:[~2023-12-18 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 20:55 [PATCH 0/4] rt-tests: cyclicdeadline: Add histogram support Crystal Wood
2023-12-06 20:55 ` [PATCH 1/4] rt-tests: Fix warnings Crystal Wood
2023-12-13 15:41 ` John Kacur
2023-12-14 15:48 ` John Kacur
2023-12-14 16:55 ` John Kacur
2023-12-18 20:15 ` Crystal Wood
2023-12-18 21:11 ` John Kacur [this message]
2023-12-06 20:55 ` [PATCH 2/4] rt-tests: cyclictest: Remove histogram totals Crystal Wood
2023-12-13 15:58 ` John Kacur
2023-12-13 16:18 ` Crystal Wood
2023-12-13 16:21 ` John Kacur
2023-12-06 20:55 ` [PATCH 3/4] rt-tests: cyclictest: Replace histogram code with library Crystal Wood
2023-12-06 20:55 ` [PATCH 4/4] rt-tests: cyclicdeadline: Add histogram support Crystal Wood
2023-12-14 16:10 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1744cf8-9fba-9989-71d3-f726f8fadde8@redhat.com \
--to=jkacur@redhat.com \
--cc=crwood@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).