From: John Kacur <jkacur@redhat.com>
To: Tomas Glozar <tglozar@redhat.com>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: [PATCH] rteval: Add relative cpulists for loads
Date: Thu, 28 Mar 2024 12:08:38 -0400 (EDT) [thread overview]
Message-ID: <716579de-2e8a-42c9-cda0-7d38c4ddf7c6@redhat.com> (raw)
In-Reply-To: <20240306090722.147221-1-tglozar@redhat.com>
On Wed, 6 Mar 2024, tglozar@redhat.com wrote:
> From: Tomas Glozar <tglozar@redhat.com>
>
> Relative cpulists were added for measurements in 64ce7848 ("rteval: Add
> relative cpulists for measurements").
>
> Add support for relative cpulists also for loads. This works the same
> way as for measurements using parse_cpulist_from_config, only difference
> is there is no --loads-run-on-isolcpus option.
You need a better description here for people who don't know what this is
about. For example, why would this be useful? There is no mention of
--only-loads
>
> Signed-off-by: Tomas Glozar <tglozar@redhat.com>
> ---
> rteval-cmd | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/rteval-cmd b/rteval-cmd
> index a5e8746..8572022 100755
> --- a/rteval-cmd
> +++ b/rteval-cmd
> @@ -340,28 +340,29 @@ if __name__ == '__main__':
> ldcfg = config.GetSection('loads')
> msrcfg = config.GetSection('measurement')
> msrcfg_cpulist_present = msrcfg.cpulist != ""
> - # Parse measurement cpulist using parse_cpulist_from_config to account for run-on-isolcpus
> + ldcfg_cpulist_present = ldcfg.cpulist != ""
I'm not a fan of this syntactic sugar it makes things wordier and less
readable IMO for programmers. I see I let you do that for msrcfg.cpulist,
but I'd prefer you put that back too
> + # Parse cpulists using parse_cpulist_from_config to account for run-on-isolcpus
I'm not religious about the 80 char term, but if you're already modifying
a comment, that overflows to the next line, why not neaten this up?
> # and relative cpusets
> cpulist = parse_cpulist_from_config(msrcfg.cpulist, msrcfg.run_on_isolcpus)
> if msrcfg_cpulist_present and not cpulist_utils.is_relative(msrcfg.cpulist) and msrcfg.run_on_isolcpus:
> logger.log(Log.WARN, "ignoring --measurement-run-on-isolcpus, since cpulist is specified")
> msrcfg.cpulist = collapse_cpulist(cpulist)
> - if ldcfg.cpulist:
> - ldcfg.cpulist = remove_offline(ldcfg.cpulist)
> + cpulist = parse_cpulist_from_config(ldcfg.cpulist, run_on_isolcpus=False)
Since run_on_isolcpus are False by default you could also just do
cpulist = parse_cpulist_from_config(ldcfg.cpulist)
since we know that we are reusing the interface in which run_on_isolcpus
are relevant, but in this case they are not, so explitly setting them to
False is confusing
> + ldcfg.cpulist = collapse_cpulist(cpulist)
> # if we only specified one set of cpus (loads or measurement)
> # default the other to the inverse of the specified list
> - if not ldcfg.cpulist and msrcfg_cpulist_present:
> + if not ldcfg_cpulist_present and msrcfg_cpulist_present:
> tmplist = expand_cpulist(msrcfg.cpulist)
> tmplist = SysTopology().invert_cpulist(tmplist)
> tmplist = cpulist_utils.online_cpulist(tmplist)
> ldcfg.cpulist = collapse_cpulist(tmplist)
> - if not msrcfg_cpulist_present and ldcfg.cpulist:
> + if not msrcfg_cpulist_present and ldcfg_cpulist_present:
> tmplist = expand_cpulist(ldcfg.cpulist)
> tmplist = SysTopology().invert_cpulist(tmplist)
> tmplist = cpulist_utils.online_cpulist(tmplist)
> msrcfg.cpulist = collapse_cpulist(tmplist)
>
> - if ldcfg.cpulist:
> + if ldcfg_cpulist_present:
> logger.log(Log.DEBUG, f"loads cpulist: {ldcfg.cpulist}")
> # if --onlyload is specified msrcfg.cpulist is unused
> if msrcfg_cpulist_present and not rtevcfg.onlyload:
> --
> 2.44.0
This works, but it needs to be more robust. For example
rteval-cmd --measurement-run-on-isolcpus --measurement-cpulist -2,4 -d5s
fails with
rteval-cmd: error: argument --measurement-cpulist: expected one argument
although this works
rteval-cmd --measurement-run-on-isolcpus --measurement-cpulist +0,-2,4
-d5s
Also, ranges are not supported, it would be nice to do
-2-5 instead of -2,3,4,5
Thanks
John
prev parent reply other threads:[~2024-03-28 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 9:07 [PATCH] rteval: Add relative cpulists for loads tglozar
2024-03-28 16:08 ` John Kacur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=716579de-2e8a-42c9-cda0-7d38c4ddf7c6@redhat.com \
--to=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglozar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).