* [PATCH resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally
@ 2021-07-14 9:53 Geert Uytterhoeven
2021-07-15 22:45 ` Heiko Stübner
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 9:53 UTC (permalink / raw
To: Heiko Stuebner, Douglas Anderson
Cc: linux-arm-kernel, linux-rockchip, linux-kernel,
Geert Uytterhoeven
Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of ROCKCHIP_GRF to
ARCH_ROCKCHIP, and ask the user in case of compile-testing.
Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/soc/rockchip/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig
index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644
--- a/drivers/soc/rockchip/Kconfig
+++ b/drivers/soc/rockchip/Kconfig
@@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST
#
config ROCKCHIP_GRF
- bool
- default y
+ bool "Rockchip General Register Files support" if COMPILE_TEST
+ default y if ARCH_ROCKCHIP
help
The General Register Files are a central component providing
special additional settings registers for a lot of soc-components.
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally
2021-07-14 9:53 [PATCH resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally Geert Uytterhoeven
@ 2021-07-15 22:45 ` Heiko Stübner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stübner @ 2021-07-15 22:45 UTC (permalink / raw
To: Douglas Anderson, Geert Uytterhoeven
Cc: linux-arm-kernel, linux-rockchip, linux-kernel,
Geert Uytterhoeven
Hi Geert,
Am Mittwoch, 14. Juli 2021, 11:53:15 CEST schrieb Geert Uytterhoeven:
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of ROCKCHIP_GRF to
> ARCH_ROCKCHIP, and ask the user in case of compile-testing.
>
> Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
I had the original patch picked already, just not pushed yet.
So hopefully nothing changed between the sends.
Heiko
> ---
> drivers/soc/rockchip/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig
> index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644
> --- a/drivers/soc/rockchip/Kconfig
> +++ b/drivers/soc/rockchip/Kconfig
> @@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST
> #
>
> config ROCKCHIP_GRF
> - bool
> - default y
> + bool "Rockchip General Register Files support" if COMPILE_TEST
> + default y if ARCH_ROCKCHIP
> help
> The General Register Files are a central component providing
> special additional settings registers for a lot of soc-components.
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-15 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-14 9:53 [PATCH resend] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally Geert Uytterhoeven
2021-07-15 22:45 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).