From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Maxime Ripard <mripard@kernel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Jani Nikula <jani.nikula@linux.intel.com>,
dri-devel@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 09/13] drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on
Date: Tue, 9 Apr 2024 10:35:49 +0200 (CEST) [thread overview]
Message-ID: <b601bc8-b016-e5af-b6ce-eb26d01413c1@linux-m68k.org> (raw)
In-Reply-To: <20240327-kms-kconfig-helpers-v3-9-eafee11b84b3@kernel.org>
Hi Maxime,
Thanks for your patch, which is now commit 4d15125d7fe637f4
("drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on") in
drm/drm-next (next-20240402 and later).
On Wed, 27 Mar 2024, Maxime Ripard wrote:
> Most of our helpers have relied on being selected so far through
> Kconfig, but that creates issues when we have multiple layers of helpers
> with some depending on others.
>
> Indeed, select doesn't select a dependency's dependencies, and thus
> isn't super intuitive. Depends on however doesn't have that limitation,
(Almost?) Everywhere else we fixed that by also selecting the
dependencies, which is more user-friendly.
> so we can just switch all the drivers that were selecting
> DRM_DISPLAY_DP_AUX_BUS to depend on it.
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>
> --- a/drivers/gpu/drm/display/Kconfig
> +++ b/drivers/gpu/drm/display/Kconfig
> @@ -9,10 +9,11 @@ config DRM_DISPLAY_HELPER
>
> config DRM_DISPLAY_DP_AUX_BUS
> tristate "DRM DisplayPort AUX bus support"
> depends on DRM
> depends on OF || COMPILE_TEST
> + default y
(quoting Linus) "What is so special about your driver, that it needs to
default to enabled?".
Especially as there is no help available for this option, so the casual
user has no idea if this is needed or not.
And a general comment for this series: many defconfigs need to be
updated, as drivers are no longer enabled because they need
functionality that now needs to be enabled explicitly.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next parent reply other threads:[~2024-04-09 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org>
[not found] ` <20240327-kms-kconfig-helpers-v3-9-eafee11b84b3@kernel.org>
2024-04-09 8:35 ` Geert Uytterhoeven [this message]
2024-04-09 9:26 ` [PATCH v3 00/13] drm/display: Convert helpers Kconfig symbols to depends on Geert Uytterhoeven
2024-04-09 10:04 ` Jani Nikula
2024-04-09 10:35 ` Geert Uytterhoeven
2024-04-09 11:12 ` Jani Nikula
2024-04-09 15:24 ` Geert Uytterhoeven
2024-04-10 19:46 ` Diederik de Haas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b601bc8-b016-e5af-b6ce-eb26d01413c1@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jani.nikula@linux.intel.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).