From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org,
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y
Date: Thu, 11 Apr 2024 01:36:20 +0300 [thread overview]
Message-ID: <20240410223620.GD23594@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240408170426.9285-21-ville.syrjala@linux.intel.com>
Hi Ville,
Thank you for the patch.
On Mon, Apr 08, 2024 at 08:04:25PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Allow rcar-du to be built with COMPILE_TEST=y for greater
> coverage. Builds fine on x86/x86_64 at least.
>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> Cc: linux-renesas-soc@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/renesas/rcar-du/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> index 2dc739db2ba3..df8b08b1e537 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/Kconfig
> +++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_RCAR_DU
> tristate "DRM Support for R-Car Display Unit"
> depends on DRM && OF
> - depends on ARM || ARM64
> + depends on ARM || ARM64 || COMPILE_TEST
I'll trust 0-day to tell us if this causes any issue on exotic (from the
R-Car DU driver's point of view) platforms.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
I expect you to push this patch, please let me know if you don't intend
to.
> depends on ARCH_RENESAS || COMPILE_TEST
> select DRM_KMS_HELPER
> select DRM_GEM_DMA_HELPER
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2024-04-10 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240408170426.9285-1-ville.syrjala@linux.intel.com>
2024-04-08 17:04 ` [PATCH 20/21] drm/rcar-du: Allow build with COMPILE_TEST=y Ville Syrjala
2024-04-09 7:26 ` Geert Uytterhoeven
2024-04-10 22:36 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240410223620.GD23594@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).