From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Olivia Wen <olivia.wen@mediatek.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
jason-ch.chen@mediatek.com, yaya.chang@mediatek.com,
teddy.chen@mediatek.com
Subject: Re: [PATCH v3 4/4] media: mediatek: imgsys: Support image processing
Date: Wed, 24 Apr 2024 09:52:28 -0600 [thread overview]
Message-ID: <ZikqvOwh5aHi6iug@p14s> (raw)
In-Reply-To: <fd24398f-a915-4e9a-9c19-4eb644178987@collabora.com>
On Wed, Apr 24, 2024 at 12:04:54PM +0200, AngeloGioacchino Del Regno wrote:
> Il 24/04/24 12:02, AngeloGioacchino Del Regno ha scritto:
> > Il 24/04/24 05:03, Olivia Wen ha scritto:
> > > Integrate the imgsys core architecture driver for image processing on
> > > the MT8188 platform.
> > >
> > > Signed-off-by: Olivia Wen <olivia.wen@mediatek.com>
> >
> > This should be reordered before introducing the 8188 scp core 1 support commit,
> > but let's check with Mathieu before sending a v4.
> >
I don't have a strong preference.
> > With that reordered,
> >
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>
> Wait, no. Sorry. I just noticed that the commit message is totally wrong.
>
> This is not a media commit, but remoteproc, and you're not adding support for
> image processing with this commit - not in media at least.
> Also, you're not adding any imgsys core architecture driver.
>
> Please fix both commit description and title.
>
I agree.
> Regards,
> Angelo
>
> >
> > > ---
> > > include/linux/remoteproc/mtk_scp.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/include/linux/remoteproc/mtk_scp.h b/include/linux/remoteproc/mtk_scp.h
> > > index 7c2b7cc9..344ff41 100644
> > > --- a/include/linux/remoteproc/mtk_scp.h
> > > +++ b/include/linux/remoteproc/mtk_scp.h
> > > @@ -43,6 +43,7 @@ enum scp_ipi_id {
> > > SCP_IPI_CROS_HOST_CMD,
> > > SCP_IPI_VDEC_LAT,
> > > SCP_IPI_VDEC_CORE,
> > > + SCP_IPI_IMGSYS_CMD,
> > > SCP_IPI_NS_SERVICE = 0xFF,
> > > SCP_IPI_MAX = 0x100,
> > > };
> >
>
prev parent reply other threads:[~2024-04-24 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 3:03 [PATCH v3 0/4] Support MT8188 SCP core 1 Olivia Wen
2024-04-24 3:03 ` [PATCH v3 1/4] dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP Olivia Wen
2024-04-24 3:03 ` [PATCH v3 2/4] remoteproc: mediatek: Support MT8188 SCP core 1 Olivia Wen
2024-04-24 10:00 ` AngeloGioacchino Del Regno
2024-04-24 3:03 ` [PATCH v3 3/4] remoteproc: mediatek: Support setting DRAM and IPI shared buffer sizes Olivia Wen
2024-04-24 10:00 ` AngeloGioacchino Del Regno
2024-04-24 3:03 ` [PATCH v3 4/4] media: mediatek: imgsys: Support image processing Olivia Wen
2024-04-24 10:02 ` AngeloGioacchino Del Regno
2024-04-24 10:04 ` AngeloGioacchino Del Regno
2024-04-24 15:52 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZikqvOwh5aHi6iug@p14s \
--to=mathieu.poirier@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jason-ch.chen@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=olivia.wen@mediatek.com \
--cc=robh@kernel.org \
--cc=teddy.chen@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=yaya.chang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).