From: Tanmay Shah <tanmay.shah@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
andersson@kernel.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: Re: [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings
Date: Tue, 19 Mar 2024 09:54:21 -0500 [thread overview]
Message-ID: <927c02e6-70cc-4af1-8e46-c4816583a3e7@amd.com> (raw)
In-Reply-To: <84923a4e-6c8e-45b7-b7a8-1a4deeb72347@linaro.org>
On 3/19/24 12:29 AM, Krzysztof Kozlowski wrote:
> On 11/03/2024 18:59, Tanmay Shah wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>>
>> Introduce bindings for TCM memory address space on AMD-xilinx Zynq
>> UltraScale+ platform. It will help in defining TCM in device-tree
>> and make it's access platform agnostic and data-driven.
>>
>> Tightly-coupled memories(TCMs) are low-latency memory that provides
>> predictable instruction execution and predictable data load/store
>> timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory
>> banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
>>
>> The TCM resources(reg, reg-names and power-domain) are documented for
>> each TCM in the R5 node. The reg and reg-names are made as required
>> properties as we don't want to hardcode TCM addresses for future
>> platforms and for zu+ legacy implementation will ensure that the
>> old dts w/o reg/reg-names works and stable ABI is maintained.
>>
>> It also extends the examples for TCM split and lockstep modes.
>>
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
>
> I responded under my reviewed-tag, but to be clear, also here:
>
> This patch has is not ready. Please do not merge.
>
Glad we could catch this before merging this.
I will wait for your reply on other thread for refactoring.
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-03-19 14:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 17:59 [PATCH v13 0/4] add zynqmp TCM bindings Tanmay Shah
2024-03-11 17:59 ` [PATCH v13 1/4] remoteproc: zynqmp: fix lockstep mode memory region Tanmay Shah
2024-03-11 17:59 ` [PATCH v13 2/4] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Tanmay Shah
2024-03-12 12:13 ` Krzysztof Kozlowski
2024-03-12 17:42 ` Tanmay Shah
2024-03-12 18:34 ` Krzysztof Kozlowski
2024-03-19 5:28 ` Krzysztof Kozlowski
2024-03-19 5:29 ` Krzysztof Kozlowski
2024-03-19 14:54 ` Tanmay Shah [this message]
2024-03-11 17:59 ` [PATCH v13 3/4] dts: zynqmp: add properties for TCM in remoteproc Tanmay Shah
2024-03-11 17:59 ` [PATCH v13 4/4] remoteproc: zynqmp: parse TCM from device tree Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927c02e6-70cc-4af1-8e46-c4816583a3e7@amd.com \
--to=tanmay.shah@amd.com \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=radhey.shyam.pandey@amd.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).