From: Kalle Valo <kvalo@kernel.org>
To: "Luca Weiss" <luca.weiss@fairphone.com>
Cc: "Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Matti Lehtimäki" <matti.lehtimaki@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org
Subject: Re: [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi
Date: Mon, 13 Nov 2023 16:10:51 +0200 [thread overview]
Message-ID: <87r0ktu4k4.fsf@kernel.org> (raw)
In-Reply-To: <CWXP3TCW3A1G.2ME0JJT3S540G@fairphone.com> (Luca Weiss's message of "Mon, 13 Nov 2023 13:50:21 +0100")
"Luca Weiss" <luca.weiss@fairphone.com> writes:
>> >> > > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> >> > > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
>> >> > > @@ -713,3 +713,7 @@ &venus {
>> >> > > firmware-name = "qcom/qcm6490/fairphone5/venus.mbn";
>> >> > > status = "okay";
>> >> > > };
>> >> > > +
>> >> > > +&wifi {
>> >> > > + status = "okay";
>> >> > qcom,ath11k-calibration-variant?
>> >>
>> >> What value would I put there for my device? Based on existing usages
>> >> (mostly for ath10k) I'd say "Fairphone_5"?
>> >
>> > I think this is fine.
>>
>> From style point of view I would prefer lower case and dashes, for
>> example "fairphone-5" but I'm just nitpicking, uppercase and underscores
>> work fine as well.
>
> I really don't mind, but I used "Fairphone_5" in v2 now, but I can
> change it for v3 if that happens if you wish.
Nah, no need to resend. That's fine.
But in the future please try to CC the ath11k list for patches like
this, easier to follow what's happening.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-11-13 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231027-sc7280-remoteprocs-v1-0-05ce95d9315a@fairphone.com>
[not found] ` <20231027-sc7280-remoteprocs-v1-1-05ce95d9315a@fairphone.com>
2023-10-28 8:01 ` [PATCH 1/9] dt-bindings: remoteproc: qcom: sc7180-pas: Fix SC7280 MPSS PD-names Krzysztof Kozlowski
[not found] ` <20231027-sc7280-remoteprocs-v1-2-05ce95d9315a@fairphone.com>
2023-10-28 8:04 ` [PATCH 2/9] arm64: dts: qcom: sc7280: Remove unused second MPSS reg Krzysztof Kozlowski
[not found] ` <20231027-sc7280-remoteprocs-v1-3-05ce95d9315a@fairphone.com>
2023-10-28 8:05 ` [PATCH 3/9] dt-bindings: remoteproc: qcom: sc7180-pas: Add SC7280 compatibles Krzysztof Kozlowski
[not found] ` <20231027-sc7280-remoteprocs-v1-6-05ce95d9315a@fairphone.com>
2023-10-28 8:05 ` [PATCH 6/9] arm64: dts: qcom: sc7280: Add ADSP node Krzysztof Kozlowski
[not found] ` <20231027-sc7280-remoteprocs-v1-7-05ce95d9315a@fairphone.com>
2023-10-28 8:06 ` [PATCH 7/9] arm64: dts: qcom: sc7280: Add CDSP node Krzysztof Kozlowski
2023-10-30 9:04 ` Mukesh Ojha
2023-10-30 9:12 ` Luca Weiss
2023-10-30 14:11 ` Doug Anderson
2023-10-30 14:43 ` Luca Weiss
2023-10-30 15:03 ` Doug Anderson
2023-10-31 6:44 ` Mukesh Ojha
2023-10-31 6:51 ` Luca Weiss
[not found] ` <20231027-sc7280-remoteprocs-v1-8-05ce95d9315a@fairphone.com>
2023-10-30 19:26 ` [PATCH 8/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable various remoteprocs Konrad Dybcio
2023-10-31 10:32 ` Luca Weiss
[not found] ` <20231027-sc7280-remoteprocs-v1-9-05ce95d9315a@fairphone.com>
2023-10-30 19:26 ` [PATCH 9/9] arm64: dts: qcom: qcm6490-fairphone-fp5: Enable WiFi Konrad Dybcio
2023-10-31 10:31 ` Luca Weiss
2023-10-31 10:32 ` Konrad Dybcio
2023-11-04 13:23 ` Dmitry Baryshkov
2023-11-13 12:22 ` Kalle Valo
2023-11-13 12:50 ` Luca Weiss
2023-11-13 14:10 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ktu4k4.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matti.lehtimaki@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).