From: Beleswar Padhi <b-padhi@ti.com>
To: <andersson@kernel.org>
Cc: <mathieu.poirier@linaro.org>, <s-anna@ti.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <u-kumar1@ti.com>, <nm@ti.com>,
<devarsht@ti.com>, <hnagalla@ti.com>
Subject: [PATCH v2 0/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1
Date: Wed, 24 Apr 2024 18:35:02 +0530 [thread overview]
Message-ID: <20240424130504.494916-1-b-padhi@ti.com> (raw)
PSC controller has a limitation that it can only power-up the second core
when the first core is in ON state. Power-state for core0 should be equal
to or higher than core1, else the kernel is seen hanging during rproc
loading.
Make the powering up of cores sequential, by waiting for the current core
to power-up before proceeding to the next core, with a timeout of 2sec.
Add a wait queue event in k3_r5_cluster_rproc_init call, that will wait
for the current core to be released from reset before proceeding with the
next core.
Also, ensure that core1 can not be powered on before core0 when starting
cores from sysfs. Similarly, ensure that core0 can not be shutdown
before core1 from sysfs.
v2: Changelog:
1) Fixed multi-line comment format
2) Included root cause of bug in comments
3) Added a patch to ensure power-up/shutdown is sequential via sysfs
Link to v1:
https://lore.kernel.org/all/20230906124756.3480579-1-a-nandan@ti.com/
Apurva Nandan (1):
remoteproc: k3-r5: Wait for core0 power-up before powering up core1
Beleswar Padhi (1):
remoteproc: k3-r5: Do not allow core1 to power up before core0 via
sysfs
drivers/remoteproc/ti_k3_r5_remoteproc.c | 51 +++++++++++++++++++++++-
1 file changed, 49 insertions(+), 2 deletions(-)
--
2.34.1
next reply other threads:[~2024-04-24 13:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:05 Beleswar Padhi [this message]
2024-04-24 13:05 ` [PATCH v2 1/2] remoteproc: k3-r5: Wait for core0 power-up before powering up core1 Beleswar Padhi
2024-04-26 17:09 ` Mathieu Poirier
2024-04-30 5:09 ` [EXTERNAL] " Beleswar Prasad Padhi
2024-04-24 13:05 ` [PATCH v2 2/2] remoteproc: k3-r5: Do not allow core1 to power up before core0 via sysfs Beleswar Padhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240424130504.494916-1-b-padhi@ti.com \
--to=b-padhi@ti.com \
--cc=andersson@kernel.org \
--cc=devarsht@ti.com \
--cc=hnagalla@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=nm@ti.com \
--cc=s-anna@ti.com \
--cc=u-kumar1@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).