From: Simon Horman <horms@kernel.org>
To: Chris Lew <quic_clew@quicinc.com>
Cc: Sarannya S <quic_sarannya@quicinc.com>,
quic_bjorande@quicinc.com, andersson@kernel.org,
mathieu.poirier@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns
Date: Thu, 4 Jan 2024 09:23:44 +0000 [thread overview]
Message-ID: <20240104092344.GE31813@kernel.org> (raw)
In-Reply-To: <3e017f77-87dd-78e1-321d-90c3e57a68d9@quicinc.com>
On Tue, Dec 26, 2023 at 04:20:03PM -0800, Chris Lew wrote:
>
>
> On 12/23/2023 5:56 AM, Simon Horman wrote:
> > [Dropped bjorn.andersson@kernel.org, as the correct address seems
> > to be andersson@kernel.org, which is already in the CC list.
> > kernel.org rejected sending this email without that update.]
> >
> > On Thu, Dec 21, 2023 at 03:36:50PM +0530, Sarannya S wrote:
> > > From: Chris Lew <quic_clew@quicinc.com>
> > >
> > > Ignore the ENODEV failures returned by kernel_sendmsg(). These errors
> > > indicate that either the local port has been closed or the remote has
> > > gone down. Neither of these scenarios are fatal and will eventually be
> > > handled through packets that are later queued on the control port.
> > >
> > > Signed-off-by: Chris Lew <quic_clew@quicinc.com>
> > > Signed-off-by: Sarannya Sasikumar <quic_sarannya@quicinc.com>
> > > ---
> > > net/qrtr/ns.c | 11 +++++++----
> > > 1 file changed, 7 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c
> > > index abb0c70..8234339 100644
> > > --- a/net/qrtr/ns.c
> > > +++ b/net/qrtr/ns.c
> > > @@ -157,7 +157,7 @@ static int service_announce_del(struct sockaddr_qrtr *dest,
> > > msg.msg_namelen = sizeof(*dest);
> > > ret = kernel_sendmsg(qrtr_ns.sock, &msg, &iv, 1, sizeof(pkt));
> > > - if (ret < 0)
> > > + if (ret < 0 && ret != -ENODEV)
> > > pr_err("failed to announce del service\n");
> > > return ret;
> >
> > Hi,
> >
> > The caller of service_announce_del() ignores it's return value.
> > So the only action on error is the pr_err() call above, and so
> > with this patch -ENODEV is indeed ignored.
> >
> > However, I wonder if it would make things clearer to the reader (me?)
> > if the return type of service_announce_del was updated void. Because
> > as things stand -ENODEV may be returned, which implies something might
> > handle that, even though it doe not.
> >
> > The above notwithstanding, this change looks good to me.
> >
> > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > ...
>
> Hi Simon, thanks for the review and suggestion. We weren't sure whether we
> should change the function prototype on these patches on the chance that
> there will be something that listens and handles this in the future. I think
> it's a good idea to change it to void and we can change it back if there is
> such a usecase in the future.
Hi Chris,
yes, I think that would be a good approach.
prev parent reply other threads:[~2024-01-04 9:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 10:06 [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns Sarannya S
2023-12-21 10:06 ` [PATCH V1] net: qrtr: ns: Return 0 if server port is not present Sarannya S
2023-12-23 13:58 ` Simon Horman
2024-01-01 18:50 ` patchwork-bot+netdevbpf
2023-12-23 13:56 ` [PATCH V1] net: qrtr: ns: Ignore ENODEV failures in ns Simon Horman
2023-12-27 0:20 ` Chris Lew
2024-01-04 9:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240104092344.GE31813@kernel.org \
--to=horms@kernel.org \
--cc=andersson@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_bjorande@quicinc.com \
--cc=quic_clew@quicinc.com \
--cc=quic_sarannya@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).