Linux-remoteproc Archive mirror
 help / color / mirror / Atom feed
From: Tanmay Shah <tanmay.shah@amd.com>
To: <linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Michal Simek <michal.simek@amd.com>
Cc: Conor Dooley <conor+dt@kernel.org>,
	Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
	Ben Levinsky <ben.levinsky@amd.com>,
	"Tanmay Shah" <tanmay.shah@amd.com>
Subject: [PATCH v4 0/3] add zynqmp TCM bindings
Date: Tue, 29 Aug 2023 11:18:57 -0700	[thread overview]
Message-ID: <20230829181900.2561194-1-tanmay.shah@amd.com> (raw)

Tightly-Coupled Memories(TCMs) are low-latency memory that provides
predictable instruction execution and predictable data load/store
timing. Each Cortex-R5F processor contains exclusive two 64 KB memory
banks on the ATCM and BTCM ports, for a total of 128 KB of memory.
In lockstep mode, both 128KB memory is accessible to the cluster.

As per ZynqMP Ultrascale+ Technical Reference Manual UG1085, following
is address space of TCM memory. The bindings in this patch series
introduces properties to accommodate following address space with
address translation between Linux and Cortex-R5 views.

|     |     |     |
| --- | --- | --- |
|      *Mode*        |   *R5 View* | *Linux view* |  Notes               |
| *Split Mode*       | *start addr*| *start addr* |                      |
| R5_0 ATCM (64 KB)  | 0x0000_0000 | 0xFFE0_0000  |                      |
| R5_0 BTCM (64 KB)  | 0x0000_2000 | 0xFFE2_0000  |                      |
| R5_1 ATCM (64 KB)  | 0x0000_0000 | 0xFFE9_0000  | alias of 0xFFE1_0000 |
| R5_1 BTCM (64 KB)  | 0x0000_2000 | 0xFFEB_0000  | alias of 0xFFE3_0000 |
|  ___               |     ___     |    ___       |                      |
| *Lockstep Mode*    |             |              |                      |
| R5_0 ATCM (128 KB) | 0x0000_0000 | 0xFFE0_0000  |                      |
| R5_0 ATCM (128 KB) | 0x0002_0000 | 0xFFE2_0000  |                      |

References:
UG1085 TCM address space: https://docs.xilinx.com/r/en-US/ug1085-zynq-ultrascale-trm/Tightly-Coupled-Memory-Address-Map

This patch series continues previous effort to upstream ZynqMP
TCM bindings:
Previous v3 version link:
https://lore.kernel.org/all/1689964908-22371-1-git-send-email-radhey.shyam.pandey@amd.com/

Changes in v4:
  - Use address-cells and size-cells value 2
  - Modify ranges property as per new value of address-cells
    and size-cells
  - Modify child node "reg" property accordingly 
  - Remove previous ack for further review
  - Introduce device-tree change with split mode representation of
    r5 cluster and each corresponding TCM
  - Introduce corresponding driver change to use TCM

Radhey Shyam Pandey (1):
  dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings

Tanmay Shah (2):
  dts: zynqmp: add properties for TCM in remoteproc
  remoteproc: zynqmp: get TCM from device-tree

 .../remoteproc/xlnx,zynqmp-r5fss.yaml         | 131 ++++++--
 arch/arm64/boot/dts/xilinx/zynqmp.dtsi        |  28 +-
 drivers/remoteproc/xlnx_r5_remoteproc.c       | 279 ++++++++++++++----
 3 files changed, 356 insertions(+), 82 deletions(-)


base-commit: 6995e2de6891c724bfeb2db33d7b87775f913ad1
-- 
2.25.1


             reply	other threads:[~2023-08-29 18:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29 18:18 Tanmay Shah [this message]
2023-08-29 18:18 ` [PATCH v4 1/3] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Tanmay Shah
2023-08-30 18:16   ` Rob Herring
2023-08-29 18:18 ` [PATCH v4 2/3] dts: zynqmp: add properties for TCM in remoteproc Tanmay Shah
2023-08-29 18:19 ` [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Tanmay Shah
2023-09-04  7:50   ` Philippe Mathieu-Daudé
2023-09-05 21:48     ` Tanmay Shah
2023-09-06  6:20       ` Philippe Mathieu-Daudé
2023-09-06 14:21         ` Tanmay Shah
2023-09-06 19:47   ` Mathieu Poirier
2023-09-06 22:02     ` Tanmay Shah
2023-09-07 17:23       ` Tanmay Shah
2023-09-07 18:08       ` Mathieu Poirier
2023-09-07 23:11         ` Tanmay Shah
2023-09-08 15:12           ` Mathieu Poirier
2023-09-25 16:33         ` Tanmay Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230829181900.2561194-1-tanmay.shah@amd.com \
    --to=tanmay.shah@amd.com \
    --cc=andersson@kernel.org \
    --cc=ben.levinsky@amd.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=michal.simek@amd.com \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).