From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
linux-rdma@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH 1/1] IB: sw: rdmavt: mr: use 'time_left' variable with wait_for_completion_timeout()
Date: Sun, 5 May 2024 15:20:06 +0200 [thread overview]
Message-ID: <ziljba4xsziurwc2espkmpmraoekfp7zymblt3ktstsjppcm4f@7apyyzi3g3zn> (raw)
In-Reply-To: <20240505130309.GA68202@unreal>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
> > > - timeout = wait_for_completion_timeout(&mr->comp, 5 * HZ);
> > > - if (!timeout) {
> > > + time_left = wait_for_completion_timeout(&mr->comp, 5 * HZ);
> > > + if (!time_left) {
> > > rvt_pr_err(rdi,
> > > "%s timeout mr %p pd %p lkey %x refcount %ld\n",
> > > t, mr, mr->pd, mr->lkey,
> >
> > Nah. Disagree. I think the code is just fine as it is.
>
> I agree with Dennis. Let's drop this patch.
Okay, I added your subsystem to the discard-list. Thanks for the review
nonetheless!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-05-05 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 21:05 [PATCH 1/1] IB: sw: rdmavt: mr: use 'time_left' variable with wait_for_completion_timeout() Wolfram Sang
2024-05-02 21:37 ` Dennis Dalessandro
2024-05-05 13:03 ` Leon Romanovsky
2024-05-05 13:20 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ziljba4xsziurwc2espkmpmraoekfp7zymblt3ktstsjppcm4f@7apyyzi3g3zn \
--to=wsa+renesas@sang-engineering.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).