From: "Margolin, Michael" <mrgolin@amazon.com>
To: Gal Pressman <gal.pressman@linux.dev>, <jgg@nvidia.com>,
<leon@kernel.org>, <linux-rdma@vger.kernel.org>
Cc: <sleybo@amazon.com>, <matua@amazon.com>,
Daniel Kranzdorf <dkkranzd@amazon.com>,
Firas Jahjah <firasj@amazon.com>
Subject: Re: [PATCH for-next] RDMA/efa: Support QP with unsolicited write w/ imm. receive
Date: Mon, 6 May 2024 15:31:39 +0300 [thread overview]
Message-ID: <e8e1d66f-b3cc-40e3-8920-284e2eba15b6@amazon.com> (raw)
In-Reply-To: <50a20417-596e-4183-93c6-63fdef526a18@linux.dev>
Hey Gal,
Thanks I'll fix that.
Michael
On 5/6/2024 2:19 PM, Gal Pressman wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> Hi Michael,
>
> On 06/05/2024 13:48, Michael Margolin wrote:
>> @@ -663,7 +666,9 @@ struct efa_admin_feature_device_attr_desc {
>> * polling is supported
>> * 3 : rdma_write - If set, RDMA Write is supported
>> * on TX queues
>> - * 31:4 : reserved - MBZ
>> + * 4 : unsolicited_write_recv - If set, unsolicited
>> + * write with imm. receive is supported
>> + * 32:5 : reserved - MBZ
> Nit: 31:5.
>
>> */
>> u32 device_caps;
>>
>> struct efa_ibv_create_qp {
>> __u32 comp_mask;
>> __u32 rq_ring_size; /* bytes */
>> __u32 sq_ring_size; /* bytes */
>> __u32 driver_qp_type;
>> + __u16 flags;
>> + __u8 reserved_90[6];
> Don't you need to verify this reserved is cleared somewhere?
>
>> };
prev parent reply other threads:[~2024-05-06 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 10:48 [PATCH for-next] RDMA/efa: Support QP with unsolicited write w/ imm. receive Michael Margolin
2024-05-06 11:19 ` Gal Pressman
2024-05-06 12:31 ` Margolin, Michael [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8e1d66f-b3cc-40e3-8920-284e2eba15b6@amazon.com \
--to=mrgolin@amazon.com \
--cc=dkkranzd@amazon.com \
--cc=firasj@amazon.com \
--cc=gal.pressman@linux.dev \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matua@amazon.com \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).